Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge does not go to the SVG figure but stop a the node border #2655

Closed
jessymallet opened this issue Nov 28, 2023 · 0 comments · Fixed by #3434
Closed

Edge does not go to the SVG figure but stop a the node border #2655

jessymallet opened this issue Nov 28, 2023 · 0 comments · Fixed by #3434
Assignees
@frouene
Labels
difficulty: challenging package: diagrams type: enhancement
Milestone
2024.5.0

Comments

@jessymallet
Copy link

Expected behavior

When user draw an edge to a custom node (such as an ellipse), the edge should be linked to the custom figure (e.g. the ellipse) and not to the border of the node.

edgeToFigure

Describe alternatives you've considered

No alternative.
@frouene frouene self-assigned this Apr 30, 2024
@frouene frouene added this to the 2024.5.0 milestone Apr 30, 2024
frouene added a commit that referenced this issue Apr 30, 2024
@frouene
[2655] Calculate custom node edge handle position to follow the real …
2071b94 
…layout

Bug: #2655
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene mentioned this issue Apr 30, 2024
Merged
39 tasks
@frouene frouene linked a pull request Apr 30, 2024 that will close this issue
[2655] Calculate custom node edge handle position to follow the real … #3434
Merged
39 tasks
frouene added a commit that referenced this issue Apr 30, 2024
@frouene
[2655] Calculate custom node edge handle position to follow the real …
107b6cd 
…layout

Bug: #2655
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue May 3, 2024
@frouene
[2655] Calculate custom node edge handle position to follow the real …
407caab 
…layout

Bug: #2655
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue May 3, 2024
@frouene
[2655] Calculate custom node edge handle position to follow the real …
06b8a51 
…layout

Bug: #2655
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue May 6, 2024
@frouene
[2655] Calculate custom node edge handle position to follow the real …
9d3c7fa 
…layout

Bug: #2655
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
gcoutable pushed a commit that referenced this issue May 6, 2024
@frouene @gcoutable
[2655] Calculate custom node edge handle position to follow the real …
e6ca26d 
…layout

Bug: #2655
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable pushed a commit that referenced this issue May 6, 2024
@frouene @gcoutable
[2655] Calculate custom node edge handle position to follow the real …
c0555f2 
…layout

Bug: #2655
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouene frouene

Labels
difficulty: challenging package: diagrams type: enhancement
Projects
None yet
Milestone
2024.5.0
Development

Successfully merging a pull request may close this issue.

[2655] Calculate custom node edge handle position to follow the real … eclipse-sirius/sirius-web
3 participants
@sbegaudeau @jessymallet @frouene