Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server-sprint - AbstractQueryRequestHandler does not close result when an exception is raised #4968

Closed
vtermanis opened this issue Apr 30, 2024 · 0 comments · Fixed by #4969
Closed

server-sprint - AbstractQueryRequestHandler does not close result when an exception is raised #4968

vtermanis opened this issue Apr 30, 2024 · 0 comments · Fixed by #4969
Labels
🐞 bug issue is a bug

Comments

@vtermanis
Copy link
Contributor

vtermanis commented Apr 30, 2024 •
edited

Current Behavior

During handling of a query in AbstractQueryRequestHandler, if an exception occurs between evaluation and return of the model & view, the result is not closed and thus, during closing of the connection it is possible that another exception is raised due to this.

Expected Behavior

Exceptions thrown in the handler should be passed on to the client (e.g. HTTP/406 for an unsupported content type) instead of sometimes resulting in an HTTP/500 error.

Steps To Reproduce

  • ℹ️ Versions: 4.3.11 / 5.0.0M2 (no significant changes spotted for affected code between these two)

We have observed this when users perform a FedX query with incompatible content type: e.g. DESCRIBE with Accept: application/sparql-results+json. Most of the time we just see this warning together with the expected HTTP/406 response but sometimes instead an HTTP/500 is returned (due to the aforementioned exception).

Version

4.3.11

Are you interested in contributing a solution yourself?

Yes.

Anything else?

One could close the result on exception, just like the connection (see draft PR). This solves it for our use-case, I believe.
However - there are other places where the result might not be closed: Once the model & view have been returned, and rendering occurs (e.g. for graph query results), the result is only closed during the QueryResults.report() call.

  1. Is it worth having a solution similar to this (given the connection is already being closed explicitly on failure)?
  2. Would it be needed elsewhere too (e.g. here)?
  3. Or should the connection-close statement be wrapped in a try-catch such that the client always gets the original failure reason and the connection-close failure is logged e.g. at warning level?

Here's a typical log message when this happens (With repo debug enabled):

rdf4j-4.3.11.log 
[WARN ] 2024-04-29 10:47:39,692 [repositories/iotics-federation] Unclosed iteration
java.lang.Throwable: Unclosed iteration
	at org.eclipse.rdf4j.sail.helpers.AbstractSailConnection.registerIteration(AbstractSailConnection.java:956)
	at org.eclipse.rdf4j.sail.helpers.AbstractSailConnection.evaluate(AbstractSailConnection.java:377)
	at org.eclipse.rdf4j.repository.sail.SailTupleQuery.evaluate(SailTupleQuery.java:53)
	at org.eclipse.rdf4j.federated.structures.FedXTupleQuery.evaluate(FedXTupleQuery.java:49)
	at org.eclipse.rdf4j.http.server.repository.handler.DefaultQueryRequestHandler.evaluateQuery(DefaultQueryRequestHandler.java:102)
	at org.eclipse.rdf4j.http.server.repository.handler.DefaultQueryRequestHandler.evaluateQuery(DefaultQueryRequestHandler.java:81)
	at org.eclipse.rdf4j.http.server.repository.handler.AbstractQueryRequestHandler.handleQueryRequest(AbstractQueryRequestHandler.java:84)
	at org.eclipse.rdf4j.http.server.repository.AbstractRepositoryController.handleRequestInternal(AbstractRepositoryController.java:53)
	at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:177)
	at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:51)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1072)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:965)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
	at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:909)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:515)
	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:583)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:212)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:181)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:115)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:181)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at com.github.ziplet.filter.compression.CompressingFilter.doFilter(CompressingFilter.java:263)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:181)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:483)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:679)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:346)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:617)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:934)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1690)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
	at java.base/java.lang.Thread.run(Unknown Source)
[ERROR] 2024-04-29 10:48:52,731 [repositories/iotics-federation] Error while handling request
org.eclipse.rdf4j.sail.SailException: Connection closed before all iterations were closed: org.eclipse.rdf4j.sail.helpers.SailBaseIteration@658577e6
	at org.eclipse.rdf4j.sail.helpers.AbstractSailConnection.forceCloseActiveOperations(AbstractSailConnection.java:1061)
	at org.eclipse.rdf4j.sail.helpers.AbstractSailConnection.close(AbstractSailConnection.java:278)
	at org.eclipse.rdf4j.repository.sail.SailRepositoryConnection.close(SailRepositoryConnection.java:248)
	at org.eclipse.rdf4j.http.server.repository.handler.AbstractQueryRequestHandler.handleQueryRequest(AbstractQueryRequestHandler.java:120)
	at org.eclipse.rdf4j.http.server.repository.AbstractRepositoryController.handleRequestInternal(AbstractRepositoryController.java:53)
	at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:177)
	at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:51)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1072)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:965)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
	at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:909)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:515)
	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:583)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:212)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:181)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:115)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:181)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at com.github.ziplet.filter.compression.CompressingFilter.doFilter(CompressingFilter.java:263)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:181)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:156)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:483)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:679)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:346)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:617)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:934)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1690)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
	at java.base/java.lang.Thread.run(Unknown Source)
@vtermanis vtermanis added the 🐞 bug issue is a bug label Apr 30, 2024
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue Apr 30, 2024
@vtermanis
eclipse-rdf4jGH-4968: server-spring - Close query result on pre-rende…
0fe681c 
…r exception

- Previously between getting the query response and rendering it
  to the desired output an exception could occur (e.g. due to unsupported
  result format) which would leave the result un-closed. This in turn
  would sometimes trigger an exception on closing the associated
  repo connection.
@vtermanis vtermanis mentioned this issue Apr 30, 2024
Merged
5 tasks
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue May 16, 2024
@vtermanis
fixup! eclipse-rdf4jGH-4968: server-spring - Close query result on pr…
fb01e2a 
…e-render exception
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue May 16, 2024
@vtermanis
fixup! eclipse-rdf4jGH-4968: server-spring - Close query result on pr…
b365276 
…e-render exception
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue May 17, 2024
@vtermanis
eclipse-rdf4jGH-4968: server-spring - Close query result on pre-rende…
f9ed099 
…r exception

- Previously between getting the query response and rendering it
  to the desired output an exception could occur (e.g. due to unsupported
  result format) which would leave the result un-closed. This in turn
  would sometimes trigger an exception on closing the associated
  repo connection.
hmottestad added a commit that referenced this issue May 21, 2024
@hmottestad
GH-4968: server-spring - Close query result on pre-render exception (#…
4626eec 
…4969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-4968: server-spring - Close query result on pre-render exception Iotic-Labs/rdf4j-pub
1 participant
@vtermanis