Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FedX - Allow for FedXConfig options to be overriden in repo config templates #4952

Closed
vtermanis opened this issue Apr 17, 2024 · 0 comments · Fixed by #4953
Closed

FedX - Allow for FedXConfig options to be overriden in repo config templates #4952

vtermanis opened this issue Apr 17, 2024 · 0 comments · Fixed by #4953
Labels
📶 enhancement issue is a new feature or improvement 📦 fedx fedx: optimized federated query support
Milestone

Comments

@vtermanis
Copy link
Contributor

vtermanis commented Apr 17, 2024

Problem description

We (at Iotics) run RDF4J as a container and configure FedX at deploy time using a config template. It would be useful to be able to override defaults of FedXConfig options such as withEnforcemaxQueryTime and withSourceSelectionCacheSpec in the template.

Preferred solution

Be able to specify FedXConfig options in the template so it's possible e.g. change the maximum query time and source selection cache configuration, e.g.:

@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>.
@prefix rep: <http://www.openrdf.org/config/repository#>.
@prefix fedx: <http://rdf4j.org/config/federation#>.

[] a rep:Repository ;
   rep:repositoryImpl [
      rep:repositoryType "fedx:FedXRepository" ;
      fedx:config [
         fedx:enforceMaxQueryTime 42 ;
         fedx:enableMonitoring true ;
      ];
   ];
   rep:repositoryID "my-federation" ;
   rdfs:label "FedX Federation" .

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

Because FedXRepositoryConfig already handles FedX repo config templates, we have not considered any alternatives.

Anything else?

We don't know whether it makes sense to expose all or just a subset of the available options. (See #4953)

@vtermanis vtermanis added the 📶 enhancement issue is a new feature or improvement label Apr 17, 2024
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue Apr 17, 2024
@aschwarte10 aschwarte10 added the 📦 fedx fedx: optimized federated query support label Apr 22, 2024
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue Apr 30, 2024
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue Apr 30, 2024
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue Apr 30, 2024
vtermanis added a commit to Iotic-Labs/rdf4j-pub that referenced this issue May 2, 2024
@aschwarte10 aschwarte10 added this to the 5.0.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📶 enhancement issue is a new feature or improvement 📦 fedx fedx: optimized federated query support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants