FocusCellOwnerDrawHighlighter doesn't remove the complete selection information

[Christopher-Hermann]

Steps to reproduce

From a fresh installation and clean workspace:
This is a follow up to #1689

Steps to reproduce

• Import the ZIP file mentioned in Keep theme coloring of cells in FocusCellOwnerDrawHighlighter #1689 as project
• Execute command "Open focus cell demo"
• Change the selection from the first line, first column to the first line, second column

A small line with the selection color can be seen in the first cell, see screenshot:

Here is some input on the issue

eclipse.platform.ui/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/FocusCellOwnerDrawHighlighter.java

Lines 108 to 118 in 1cd9f4f

	private void removeSelectionInformation(Event event, ViewerCell cell) {
	GC gc = event.gc;
	if (Util.isGtk()) {
	// On GTK, the line is highlighted even though the SELECTED flag is removed. To
	// fix this issue, the background must be overwridden
	gc.setBackground(cell.getViewerRow().getBackground(cell.getColumnIndex()));
	gc.fillRectangle(cell.getBounds());
	}
	gc.setForeground(cell.getViewerRow().getForeground(cell.getColumnIndex()));
	event.detail &= ~SWT.SELECTED;
	}

The FocusCellOwnerDrawHighlighter removes the selection information of the selected line so that only the selected cell is highlighted. Somehow not the complete selected area is removed.

Community

• [/] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[fedejeanne]

@Christopher-Hermann thank you for reporting it!

I assigned this issue to you as requested in #1690 (comment).