Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some ResourceInitialSelectionTest tests fail intermittently in the I-build on Mac #294

Open
ktatavarthi opened this issue Aug 25, 2022 · 5 comments · May be fixed by #1865
Open

Some ResourceInitialSelectionTest tests fail intermittently in the I-build on Mac #294

ktatavarthi opened this issue Aug 25, 2022 · 5 comments · May be fixed by #1865
Labels
help wanted Extra attention is needed macOS happens on macOS test junit test related things

Comments

@ktatavarthi
Copy link
Member

The tests

  • org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testMultiSelectionAndOneInitialSelectionWithInitialPattern
One file should be selected by default expected:<[L/org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest_1661392833486/foo.txt]> but was:<[]>

junit.framework.AssertionFailedError: One file should be selected by default expected:<[L/org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest_1661392833486/foo.txt]> but was:<[]>
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.failNotEquals(Assert.java:329)
at junit.framework.Assert.assertEquals(Assert.java:78)
at junit.framework.TestCase.assertEquals(TestCase.java:238)
at org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testMultiSelectionAndOneInitialSelectionWithInitialPattern(ResourceInitialSelectionTest.java:227)
  • org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testSingleSelectionAndNoInitialSelectionWithInitialPattern
One file should be selected by default

junit.framework.AssertionFailedError: One file should be selected by default
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertFalse(Assert.java:39)
at junit.framework.TestCase.assertFalse(TestCase.java:208)
at org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testSingleSelectionAndNoInitialSelectionWithInitialPattern(ResourceInitialSelectionTest.java:98)

failed in I-Build I20220824-1800 on Mac
@ktatavarthi ktatavarthi added the macOS happens on macOS label Aug 25, 2022
@ktatavarthi
Copy link
Member Author

This issues is created as a follow up to Bug 576361

@ktatavarthi ktatavarthi mentioned this issue Aug 25, 2022
Closed
13 tasks
@ktatavarthi
Copy link
Member Author

The test org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testMultiSelectionAndTwoInitialFilteredSelections fails on MacM1 with the below error

Two files should be selected by default 

junit.framework.AssertionFailedError: Two files should be selected by default
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.TestCase.assertTrue(TestCase.java:192)
at org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testMultiSelectionAndTwoInitialFilteredSelections(ResourceInitialSelectionTest.java:331)

@ktatavarthi ktatavarthi mentioned this issue Sep 30, 2022
Closed
13 tasks
@HeikoKlare
Copy link
Contributor

Test failure still occurs: https://github.com/eclipse-platform/eclipse.platform.ui/pull/970/checks?check_run_id=15356957783

@HeikoKlare HeikoKlare mentioned this issue Jul 26, 2023
Merged
@Shee43
Copy link
Contributor

Shee43 commented Sep 29, 2023 •
edited

The test org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testMultiSelectionAndTwoInitialNonExistingSelectionWithInitialPattern fails on win-32 with the below error in build I20230927-1800

Problems encountered while deleting resources.

java.lang.AssertionError: Problems encountered while deleting resources.
at org.eclipse.ui.tests.dialogs.UIWorkingSetWizardsAuto.createAssertionError(UIWorkingSetWizardsAuto.java:156)
at org.eclipse.ui.tests.dialogs.UIWorkingSetWizardsAuto.cleanupWorkspace(UIWorkingSetWizardsAuto.java:141)
at org.eclipse.ui.tests.dialogs.UIWorkingSetWizardsAuto.doTearDown(UIWorkingSetWizardsAuto.java:123)
at org.eclipse.ui.tests.harness.util.UITestCase.tearDown(UITestCase.java:214)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@HeikoKlare HeikoKlare mentioned this issue Sep 29, 2023
Merged
@vogella vogella mentioned this issue Oct 18, 2023
Merged
@jukzi jukzi added the test junit test related things label Dec 11, 2023
@jukzi jukzi mentioned this issue Dec 11, 2023
Closed
@jukzi
Copy link
Contributor

jukzi commented Dec 11, 2023

also

unit.framework.AssertionFailedError: Two files should be selected by default
	at junit.framework.TestCase.assertTrue(TestCase.java:192)
	at org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest.testMultiSelectionAndTwoInitialSelectionsWithInitialPattern(ResourceInitialSelectionTest.java:306)

https://github.com/eclipse-platform/eclipse.platform.ui/pull/1384/checks?check_run_id=19379975992

@jukzi jukzi mentioned this issue Dec 11, 2023
Merged
@jukzi jukzi added the help wanted Extra attention is needed label Dec 11, 2023
@HeikoKlare HeikoKlare mentioned this issue Jan 19, 2024
Merged
@BeckerWdf BeckerWdf mentioned this issue Mar 8, 2024
Merged
@HeikoKlare HeikoKlare mentioned this issue Mar 23, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Apr 29, 2024
@HeikoKlare
Use WorkspaceTestRule in UITestCase eclipse-platform#291
42f0c6c 
All specializations of UITestCase operate on a workspace, for which the
JUnit 4 WorkspaceTestRule exist to ensure proper workspace cleanup,
including deletion of all projects and restoring workspace default
settings. Currently, such cleanup is up to the individual test case and
not performed uniformly and consistently.

With this change, the WorkspaceTestRule is applied to all
specializations of WorkspaceTestRule. As a first direct application, the
manual project deletion in ResourceInitialSelectionTest, which is
currently failing randomly, is removed and replaced by the general
cleanup functionality.

May fix eclipse-platform#294
This was referenced Apr 29, 2024
Draft
Merged
@HeikoKlare HeikoKlare mentioned this issue May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed macOS happens on macOS test junit test related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WiP] Use WorkspaceTestRule in UITestCase #291 HeikoKlare/eclipse.platform.ui
4 participants
@HeikoKlare @ktatavarthi @jukzi @Shee43