Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Generic Editor] Add a Refactorings menu to the Generic Editor to allow command contributions #1785

Open
2 tasks done
ylussaud opened this issue Mar 29, 2024 · 1 comment
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@ylussaud
Copy link

Let's make sure issue is not already fixed in latest builds first.

Suggestion

I made a pull request to the LSP4E project and we think it would be better to move the Refactorings menu to the Generic Editor. This would allow anyone extending the Generic Editor to contribute refactoring commands in the same menu.

Community

If you think it's a good idea I can provide a pull request.

  • I understand suggesting an enhancement doesn't mandate anyone to implement it. Other contributors may consider this suggestion, or not, at their own convenience. The most efficient way to get it fixed is that I implement it myself and contribute it back as a good quality patch to the project.
@mickaelistria
Copy link
Contributor

+1, it's definitely a good idea. As generic editor is about code edition, it seems normal to expect that the editor provides a refactoring menu directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants