Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generic editor] Support multiple IPresentationReconcilers #1328

Open
laeubi opened this issue Nov 26, 2023 · 0 comments · May be fixed by #1329
Open

[generic editor] Support multiple IPresentationReconcilers #1328

laeubi opened this issue Nov 26, 2023 · 0 comments · May be fixed by #1329
Labels
enhancement New feature or request

Comments

@laeubi
Copy link
Contributor

laeubi commented Nov 26, 2023

Currently org.eclipse.ui.internal.genericeditor.ExtensionBasedTextViewerConfiguration.getPresentationReconciler(ISourceViewer) only use the first IPresentationReconciler it finds in the registry. Not that this is random, it currently hinders extensions to provide additional presentation for different content types.

Instead it should only use the first if there is only one and otherwise install a wrapper that delegates to the individual items.

@mickaelistria WDYT?
@laeubi laeubi added the enhancement New feature or request label Nov 26, 2023
@laeubi laeubi transferred this issue from eclipse-platform/eclipse.platform Nov 26, 2023
@laeubi laeubi linked a pull request Nov 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiple IPresentationReconciler in generic editor laeubi/eclipse.platform.ui
1 participant
@laeubi