Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Older binaries are not deleted #1095

Closed
Phillipus opened this issue Mar 10, 2024 · 4 comments · Fixed by #1100
Closed

Older binaries are not deleted #1095

Phillipus opened this issue Mar 10, 2024 · 4 comments · Fixed by #1100
Labels
bug Something isn't working regression Something that used to work

Comments

@Phillipus
Copy link
Contributor

Phillipus commented Mar 10, 2024 •
edited

Discovered by @chirontt here but perhaps better opened as an issue rather than a discussion to get more visibility.

This is since 47db2f0
@Phillipus
Copy link
Contributor Author

Phillipus commented Mar 10, 2024 •
edited

The latest I-builds contain both the old and new binaries in the org.eclipse.swt.xxxx jar files.

For example: https://www.eclipse.org/downloads/download.php?file=/eclipse/updates/4.32-I-builds/I20240310-0340/plugins/org.eclipse.swt.win32.win32.x86_64_3.126.0.v20240310-0745.jar

@jukzi
Copy link
Contributor

jukzi commented Mar 11, 2024

image

@jukzi jukzi added the bug Something isn't working label Mar 11, 2024
@iloveeclipse iloveeclipse added the regression Something that used to work label Mar 11, 2024
iloveeclipse added a commit to iloveeclipse/eclipse.platform.swt that referenced this issue Mar 11, 2024
@iloveeclipse
Remove all existing native libraries before copying new compiled
50e796a 
If make_common.mak changes, code in 'Check if SWT-binaries build is
needed' stage, that is supposed to delete native libraries, simply
doesn't delete anything as it relies on getSWTVersions() that reads
(changed) versions.

Instead, try to delete *every* library file stored in git before copying
freshly compiled ones during 'Collect and sign binaries' stage.

Fixes eclipse-platform#1095
@iloveeclipse iloveeclipse mentioned this issue Mar 11, 2024
Merged
@iloveeclipse
Copy link
Member

@HannesWell : please look at this issue, I've described why it happens in #1100.

I've pushed a possible fix (#1100) but I fear that is too simple and we will miss some native libraries that aren't built yet (like https://github.com/eclipse-platform/eclipse.platform.swt/blob/d80b3268354ffc76afe1d3c2cf6cf9bb881c2c86/binaries/org.eclipse.swt.win32.win32.x86_64/WebView2Loader.dll).

iloveeclipse added a commit to iloveeclipse/eclipse.platform.swt that referenced this issue Mar 11, 2024
@iloveeclipse
Remove all existing native *swt* libraries before copying new
f739f8e 
If make_common.mak changes, code in 'Check if SWT-binaries build is
needed' stage, that is supposed to delete native libraries, simply
doesn't delete anything as it relies on getSWTVersions() that reads
(changed) versions.

Instead, try to delete every *swt* library file stored in git before
copying freshly compiled ones during 'Collect and sign binaries' stage.

Fixes eclipse-platform#1095
HannesWell pushed a commit to iloveeclipse/eclipse.platform.swt that referenced this issue Mar 12, 2024
@iloveeclipse @HannesWell
Remove all existing native *swt* libraries before copying new
8b62496 
If make_common.mak changes, code in 'Check if SWT-binaries build is
needed' stage, that is supposed to delete native libraries, simply
doesn't delete anything as it relies on getSWTVersions() that reads
(changed) versions.

Instead, try to delete every *swt* library file stored in git before
copying freshly compiled ones during 'Collect and sign binaries' stage.

Fixes eclipse-platform#1095
HannesWell pushed a commit to iloveeclipse/eclipse.platform.swt that referenced this issue Mar 12, 2024
@iloveeclipse @HannesWell
Remove all existing native *swt* libraries before copying new
eea222c 
If make_common.mak changes, code in 'Check if SWT-binaries build is
needed' stage, that is supposed to delete native libraries, simply
doesn't delete anything as it relies on getSWTVersions() that reads
(changed) versions.

Instead, try to delete every *swt* library file stored in git before
copying freshly compiled ones during 'Collect and sign binaries' stage.

Fixes eclipse-platform#1095
HannesWell pushed a commit to iloveeclipse/eclipse.platform.swt that referenced this issue Mar 12, 2024
@iloveeclipse @HannesWell
Remove all existing native *swt* libraries before copying new
744c816 
If 'make_common.mak' is changed manually (e.g. during new release-cycle
preparation), the code in 'Check if SWT-binaries build is needed' stage,
that is supposed to delete native libraries, doesn't delete anything as
it relies on getSWTVersions() that reads the (already changed) versions.

Adjust the file-pattern to delete every *swt* library file stored in git
instead, regardless of its exact version.

Fixes eclipse-platform#1095
HannesWell added a commit to iloveeclipse/eclipse.platform.swt that referenced this issue Mar 12, 2024
@iloveeclipse @HannesWell
Remove all existing native *swt* libraries before copying new
18d018e 
If 'make_common.mak' is changed manually (e.g. during new release-cycle
preparation), the code in 'Check if SWT-binaries build is needed' stage,
that is supposed to delete native libraries, doesn't delete anything as
it relies on getSWTVersions() that reads the (already changed) versions.

Adjust the file-pattern to delete every *swt* library file stored in git
instead, regardless of its exact version.

Fixes eclipse-platform#1095

Co-authored-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
HannesWell added a commit to iloveeclipse/eclipse.platform.swt that referenced this issue Mar 12, 2024
@iloveeclipse @HannesWell
Remove all existing native *swt* libraries before copying new
8fcaabd 
If 'make_common.mak' is changed manually (e.g. during new release-cycle
preparation), the code in 'Check if SWT-binaries build is needed' stage,
that is supposed to delete native libraries, doesn't delete anything as
it relies on getSWTVersions() that reads the (already changed) versions.

Adjust the file-pattern to delete every *swt* library file stored in git
instead, regardless of its exact version.

Fixes eclipse-platform#1095

Co-authored-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
HannesWell added a commit that referenced this issue Mar 12, 2024
@iloveeclipse @HannesWell
Remove all existing native *swt* libraries before copying new
c9a4f7d 
If 'make_common.mak' is changed manually (e.g. during new release-cycle
preparation), the code in 'Check if SWT-binaries build is needed' stage,
that is supposed to delete native libraries, doesn't delete anything as
it relies on getSWTVersions() that reads the (already changed) versions.

Adjust the file-pattern to delete every *swt* library file stored in git
instead, regardless of its exact version.

Fixes #1095

Co-authored-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
@HannesWell
Copy link
Member

Resolved by running the master build with enforced native-build after #1100 has been submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression Something that used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all existing native libraries before copying new compiled iloveeclipse/eclipse.platform.swt
4 participants
@Phillipus @iloveeclipse @HannesWell @jukzi