Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help wanted][win32] SWT Support for Windows on ARM #1019

Closed
kwin opened this issue Jan 31, 2024 · 23 comments · Fixed by #1045
Closed

[help wanted][win32] SWT Support for Windows on ARM #1019

kwin opened this issue Jan 31, 2024 · 23 comments · Fixed by #1045
Labels
enhancement New feature or request help wanted Extra attention is needed Windows Happens on Windows OS

Comments

@kwin
Copy link

kwin commented Jan 31, 2024

As there is now also Windows for ARM and the necessary tooling in place (https://learn.microsoft.com/en-us/windows/arm/overview) it would be nice to provide SWT for Windows ARM as well

@jukzi
Copy link
Contributor

jukzi commented Jan 31, 2024

Please provide PR ,Hardware for running tests, people that for maintance ...

@jukzi jukzi added enhancement New feature or request wontfix This will not be worked on Windows Happens on Windows OS labels Jan 31, 2024
@merks
Copy link
Contributor

merks commented Jan 31, 2024

Just asking isn’t going to make it happed as is the case for the installer

eclipse-oomph/oomph#63

Note that an equinox launcher is needed too.

@kwin
Copy link
Author

kwin commented Jan 31, 2024

Usually in open source you also track interest in features via issues. That allows other users to vote and by that gain some insights on importance of features. Obviously raising a feature request does not mean it will ever be implemented. Still this kind of transparency doesn’t hurt IMHO.

@jukzi
Copy link
Contributor

jukzi commented Feb 1, 2024

Closing as not planned.

@jukzi jukzi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
@mickaelistria
Copy link
Contributor

Let's reopen with "helpwanted", to clarify that the project would really welcome this addition, but won't achieve it with current resources.

@mickaelistria mickaelistria reopened this Feb 1, 2024
@mickaelistria mickaelistria added help wanted Extra attention is needed and removed wontfix This will not be worked on labels Feb 1, 2024
@merks
Copy link
Contributor

merks commented Feb 1, 2024

Note that I asked for more transparency here but did not get a response:

eclipse-oomph/oomph#63 (comment)

Transparency normally goes both ways. There was talking of linking issues, but I see no equinox issue and I know of no adoptium issue.

@kwin
Copy link
Author

kwin commented Feb 1, 2024

but I see no equinox issue and I know of no adoptium issue.

This is not a prerequisite for this issue AFAIK, but for Adoptium there is adoptium/adoptium-support#616 (also mentioned in eclipse-oomph/oomph#63). Feel free to raise one for Equinox, I wasn't aware that this requires/embeds native parts.

@jukzi
Copy link
Contributor

jukzi commented Feb 1, 2024

Pointless to have a wish list as long as no big player offers the required funding.

@fipro78
Copy link

fipro78 commented Feb 1, 2024

Just in case, there was already such a request at the platform: eclipse-platform/eclipse.platform.releng.aggregator#597

Only to add the reference, as there was already discussions on this.

@jukzi
Copy link
Contributor

jukzi commented Feb 1, 2024

that issue was already closed as not planned too, so please stop spamming new issues without solving the resource issue.

@laeubi
Copy link
Contributor

laeubi commented Feb 1, 2024

@jukzi I don't see that it hurts to have such issue instead of having this came up multiple times, an open issue does not cost us a thing but can help to get others aware that we need help here.

@laeubi laeubi pinned this issue Feb 1, 2024
@laeubi laeubi changed the title Provide SWT for Windows on ARM [help wanted] SWT Support for Windows on ARM Feb 1, 2024
@merks
Copy link
Contributor

merks commented Feb 1, 2024

but I see no equinox issue and I know of no adoptium issue.

This is not a prerequisite for this issue AFAIK, but for Adoptium there is adoptium/adoptium-support#616 (also mentioned in eclipse-oomph/oomph#63). Feel free to raise one for Equinox, I wasn't aware that this requires/embeds native parts.

Well, you seem to want an installer too, and there won't be one without a launcher. Personally I'm just not convinced in the need nor value for such open wish list items mostly so you can personally track things from afar. These lists are also our project issue lists (SWT has hundreds of issues) and when we don't plan something and you don't plan something, then there is no plan. Furthermore, while we might be idealistic and think/home/believe/wish that a helpwanted will attract help, this is a seriously deep and challenging problem that will not be helped by only some well-intended users. It will only be helped with also some involvement from an organization with deeper pockets (hardware), and, once completed it will have a maintenance/testing burden across many projects. Yes, one more issue doesn't turn overall, but when you say that 1000 times, it becomes less true.

@laeubi
Copy link
Contributor

laeubi commented Feb 1, 2024

@jonahgraham can you please bring up this topic on the Eclipse IDE WG, it seems one can buy virtual ARM hardware on Azure: https://learn.microsoft.com/en-us/windows/arm/create-arm-vm
I think if we just have one machine this would be enough for initial work on this and users would probably love to use Eclipse natively without emulation....

@laeubi laeubi changed the title [help wanted] SWT Support for Windows on ARM [help wanted][win32] SWT Support for Windows on ARM Feb 1, 2024
@mickaelistria
Copy link
Contributor

Pointless to have a wish list as long as no big player offers the required funding.

Keeping such issues temporarily open is one way of fishing new contributors and demonstrate project openness. We must keep in mind that the resources of the project in the future are not the ones of the present (and it must be one of the goal of the community to constantly grow with new contributors and more resources). So while we cannot achieve it today, and while no-one in the current community plans to work on it, the report can still be welcome, hoping it can attract some more contributors to care about it in a near future.
If not activity takes place on this ticket for some time, then we can close it like we didi eclipse-platform/eclipse.platform.releng.aggregator#597 when we have a need to cleanup the tracker. But in the meantime, keeping it open is slightly more likely to provide good outcome than closing it.

@hmartinez82
Copy link
Contributor

hmartinez82 commented Feb 11, 2024

I have a Windows Devkit (the so called Project Volterra) with Windows on ARM where I can help if a VM to run CI builds is required. I just need instructions on how to build SWT even locally on x64 first. (I'm not a Java dev 😓)

@laeubi
Copy link
Contributor

laeubi commented Feb 11, 2024

@hmartinez82 great to hear you want help out, to contribute a runner you need to open a ticket on the helpdesk here is an example:

there you should note that you want your runner be added to the SWT Jenkins:

the IT team will then ask you for additional details in my case it was

  • server name
  • server description (e.g. OS, arch, etc)
  • server IP
  • user name (e.g. jenkins)

Additionally it would be good to mention how many concurrent build should be allowed on this node, you maybe also want to take a look here to get some idea what needs to be setup:
https://www.jenkins.io/doc/book/managing/nodes/#installing-a-jenkins-agent-on-windows

At least for a few months until you guys get a permanent one from ARM (they are donating hardware for projects trying to be ported).

If you have further information please share them here, or you can even mention them in the help-desk so the IT team probably can take the necessary actions!

@laeubi
Copy link
Contributor

laeubi commented Feb 11, 2024

I just need instructions on how to build SWT even locally on x64 first. (I'm not a Java dev 😓)

@chirontt seems to have things already setup so he could probably help here.

@chirontt would you mind to open a PR with your changes to the SWT repository? Then @hmartinez82 could checkout your PR and additionally we can test if the provided build note actually works and it seems logically to start with SWT.

@chirontt
Copy link
Contributor

PR submitted: eclipse-platform/eclipse.platform.swt/#1045

@SyntevoAlex @hmartinez82 please review it and provide comments, especially about the cross-compiling, thanks. Once the PR is accepted, please create and check in the swt*.dll files for WoA to the repo, and I'll submit the 2nd part for the org.eclipse.swt.win32.win32.aarch64 binaries module.

As @merks mentioned, equinox launchers for Windows Arm64 need also be compiled, and I'll submit a PR for it soon (to the equinox project.)

@hmartinez82
Copy link
Contributor

hmartinez82 commented Feb 11, 2024

@SyntevoAlex
Copy link
Member

Now that master is open again, I suggest that we merge this.
Any objections?

@iloveeclipse
Copy link
Member

Please rebase and check if any version updates are needed in build files first for 4.32.

@fedejeanne
Copy link
Contributor

@laeubi should this issue be unpinned?

@HannesWell HannesWell unpinned this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed Windows Happens on Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.