From 7479681ce2cd75b1adb10220d061d83e4f83e2cd Mon Sep 17 00:00:00 2001
From: Hannes Wellmann <wellmann.hannes1@gmx.net>
Date: Tue, 12 Mar 2024 19:13:27 +0100
Subject: [PATCH] Make all API leak-issues errors and fail build on API
 warnings

---
 binaries/.settings/org.eclipse.pde.api.tools.prefs | 12 ++++++------
 binaries/pom.xml                                   |  1 +
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/binaries/.settings/org.eclipse.pde.api.tools.prefs b/binaries/.settings/org.eclipse.pde.api.tools.prefs
index 9ca47470c1b..970d959820b 100644
--- a/binaries/.settings/org.eclipse.pde.api.tools.prefs
+++ b/binaries/.settings/org.eclipse.pde.api.tools.prefs
@@ -66,11 +66,11 @@ INTERFACE_ELEMENT_TYPE_REMOVED_TYPE_PARAMETER=Error
 INVALID_ANNOTATION=Error
 INVALID_JAVADOC_TAG=Error
 INVALID_REFERENCE_IN_SYSTEM_LIBRARIES=Error
-LEAK_EXTEND=Warning
-LEAK_FIELD_DECL=Warning
-LEAK_IMPLEMENT=Warning
-LEAK_METHOD_PARAM=Warning
-LEAK_METHOD_RETURN_TYPE=Warning
+LEAK_EXTEND=Error
+LEAK_FIELD_DECL=Error
+LEAK_IMPLEMENT=Error
+LEAK_METHOD_PARAM=Error
+LEAK_METHOD_RETURN_TYPE=Error
 METHOD_ELEMENT_TYPE_ADDED_RESTRICTIONS=Error
 METHOD_ELEMENT_TYPE_ADDED_TYPE_PARAMETER=Error
 METHOD_ELEMENT_TYPE_CHANGED_DECREASE_ACCESS=Error
@@ -101,4 +101,4 @@ invalid_since_tag_version=Error
 malformed_since_tag=Error
 missing_since_tag=Error
 report_api_breakage_when_major_version_incremented=Disabled
-report_resolution_errors_api_component=Warning
+report_resolution_errors_api_component=Error
diff --git a/binaries/pom.xml b/binaries/pom.xml
index 42f8b9c298f..667fa41d788 100644
--- a/binaries/pom.xml
+++ b/binaries/pom.xml
@@ -49,6 +49,7 @@
 				<version>${tycho.version}</version>
 				<configuration>
 					<addSourceFolders>true</addSourceFolders>
+					<failOnWarning>true</failOnWarning>
 				</configuration>
 			</plugin>
 			<plugin>