Eclipse IDE Dark Theme color issues (windows)

[jukzi]

"Dark" Theme looks different (wrong) then "Light" Theme . Screenshots from windows 10:

1. "Welcome page" is still in light colors
2. Focused Tab (for example "welcome") is blue underlined - while there is no underline in Light theme (Allow to easily spot which CTabFolder/CTabItem has focus (eg in Workbench) eclipse.platform.swt#55)
   3.the opposite is true for "Run Configurations" Dialog: in dark theme focused Tab "Main" is NOT blue, while in Light them it IS overlined
   
   
3. the text input fields (for example "Location" in "Run Configurations") have wrong background color. They are not as black in Dark mode as white in Light
4. same is true for combo boxes (like "Run a product") where one can see the background color that should be used behind the drop down arrow
5. Also sometimes(!) the combos are sometimes blue in dark mode (for example "Launch with" when "Plug-ins" are selected) while not blue in light theme in the same situation:
   
   
6. The Tracing Options are hardly readable (grey on grey):
   
7. deactivated combo boxes are hardly readable too:
   

[vogella]

The CSS settings are located in org.eclipse.ui.themes in the eclipse.platform.ui repo and we rely on SWT API to behave dark aware. The welcome screen is dark for me, see below, please create a new issue for eclipse.platform.ua and ask @BeckerWdf to look at it, IIRC he implemented the dark support for the welcome screen. Might be that Win10 broke something.

The blue highlight of the tab can be configured, @mickaelistria implemented it in SWT. I think we "only" need to active it or turn the CSS specific setting of in the dark theme to activate it.

[vogella]

[jukzi]

The CSS settings are located in org.eclipse.ui.themes in the eclipse.platform.ui repo

In dark theme a new Composite(parent, style) shows another backgroundcolor then anything that extends Composite. Even a anonymous new Composite(parent, style) { /** nothing changed **/} already shows wrong background.
And there are many extensions of Composite in eclipse.... how does that work? Why does any extension of Composite behaves different? Are the classnames listed in the e4-dark_globalstyle.css textual compared somewhere instead of instanceof? should be java.lang.Class.isAssignableFrom(Class<?>)

[RedeemerSK]

Another issue, regression from 2022-06 (4.24) to 2022-09 (4.25):
Background color of buttons/icons does not change neither on mouse hover nor when being enabled (for toggles) / pressed (on action buttons):

(2022-06)

(2022-09)

It seems backgrounds of toggle & action buttons on every view are broken. Not only on hover / press, but also default background is lighter then rest of local toolbar background (see 2nd picture, 3 buttons in "Package Explorer" toolbar).

On main toolbar however, some buttons are ok (eg. "Search" also with dropdown menu arrow or "Skip All Breakpoints" which works in main toolbar even if it's broken in "Breakpoints" view), some are half-ok (eg. for "New" only the dropdown menu arrow background seems ok, for icon itself it's broken), and some are broken (eg. perspectives icons or "Open Terminal" icon).

Minime & Maximize & Restore buttons of views are all working (as well as views icons when minimized).

In short, it's quite inconsistent where the issue manifests, however some patterns are there.
EDIT: yeah, looks like @jukzi above may already have an answer for why there's this inconsistency.

(Windows 10)