-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JavaSE-23 EE to launching #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurtakov
changed the title
Add JavaSE-23 EEs to launching
Add JavaSE-23 EE to launching
Apr 12, 2024
As jdt.core still doesn't have the Java 23 support JavaSE-23 doesn't appear in the various places with EE lists but allows Java 23 JVM to be seen as super set of Java 22. Work for eclipse-pde/eclipse.pde#1225
jjohnstn
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This caused eclipse-pde/eclipse.pde#1227 :-( |
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Apr 15, 2024
They are added for runtime detection and launching of Java 23 as detected in eclipse-pde/eclipse.pde#1227 and eclipse-jdt/eclipse.jdt.debug#426 .
3 tasks
iloveeclipse
pushed a commit
to eclipse-jdt/eclipse.jdt.core
that referenced
this pull request
Apr 15, 2024
They are added for runtime detection and launching of Java 23 as detected in eclipse-pde/eclipse.pde#1227 and eclipse-jdt/eclipse.jdt.debug#426 .
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Apr 17, 2024
They are added for runtime detection and launching of Java 23 as detected in eclipse-pde/eclipse.pde#1227 and eclipse-jdt/eclipse.jdt.debug#426 .
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Apr 22, 2024
They are added for runtime detection and launching of Java 23 as detected in eclipse-pde/eclipse.pde#1227 and eclipse-jdt/eclipse.jdt.debug#426 .
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
As jdt.core still doesn't have the Java 23 support JavaSE-23 doesn't appear in the various places with EE lists but allows Java 23 JVM to be seen as super set of Java 22.
Fixes eclipse-pde/eclipse.pde#1225
How to test
Running child eclipse with Java 23 jvm should work without the validation errors shown in eclipse-pde/eclipse.pde#1225 .
Author checklist