Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaSE-23 EE to launching #426

Merged
merged 1 commit into from Apr 12, 2024
Merged

Conversation

akurtakov
Copy link
Contributor

What it does

As jdt.core still doesn't have the Java 23 support JavaSE-23 doesn't appear in the various places with EE lists but allows Java 23 JVM to be seen as super set of Java 22.
Fixes eclipse-pde/eclipse.pde#1225

How to test

Running child eclipse with Java 23 jvm should work without the validation errors shown in eclipse-pde/eclipse.pde#1225 .

Author checklist

@akurtakov akurtakov changed the title Add JavaSE-23 EEs to launching Add JavaSE-23 EE to launching Apr 12, 2024
@akurtakov akurtakov self-assigned this Apr 12, 2024
As jdt.core still doesn't have the Java 23 support JavaSE-23 doesn't
appear in the various places with EE lists but allows Java 23 JVM to be
seen as super set of Java 22.
Work for eclipse-pde/eclipse.pde#1225
Copy link
Contributor

@jjohnstn jjohnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jjohnstn jjohnstn merged commit 60da9ec into eclipse-jdt:master Apr 12, 2024
10 checks passed
@iloveeclipse
Copy link
Member

This caused eclipse-pde/eclipse.pde#1227 :-(

akurtakov added a commit to akurtakov/eclipse.jdt.core that referenced this pull request Apr 15, 2024
They are added for runtime detection and launching of Java 23 as
detected in eclipse-pde/eclipse.pde#1227 and
eclipse-jdt/eclipse.jdt.debug#426 .
iloveeclipse pushed a commit to eclipse-jdt/eclipse.jdt.core that referenced this pull request Apr 15, 2024
They are added for runtime detection and launching of Java 23 as
detected in eclipse-pde/eclipse.pde#1227 and
eclipse-jdt/eclipse.jdt.debug#426 .
akurtakov added a commit to akurtakov/eclipse.jdt.core that referenced this pull request Apr 17, 2024
They are added for runtime detection and launching of Java 23 as
detected in eclipse-pde/eclipse.pde#1227 and
eclipse-jdt/eclipse.jdt.debug#426 .
akurtakov added a commit to akurtakov/eclipse.jdt.core that referenced this pull request Apr 22, 2024
They are added for runtime detection and launching of Java 23 as
detected in eclipse-pde/eclipse.pde#1227 and
eclipse-jdt/eclipse.jdt.debug#426 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation errors starting Eclipse launch with Java 23
3 participants