Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ECLIPSE_HOME from PDE and instead let it be provided by JDT #1146

Open
laeubi opened this issue Feb 10, 2024 · 0 comments
Open

Remove ECLIPSE_HOME from PDE and instead let it be provided by JDT #1146

laeubi opened this issue Feb 10, 2024 · 0 comments

Comments

@laeubi
Copy link
Contributor

laeubi commented Feb 10, 2024

See discussion here:

To give some context:

  • Seems not used anywhere beside the default location
  • org.eclipse.debug.internal.core.SystemVariableResolver even resolves it as a system variable
  • Effectively can only be different with a target platform whose first location is a profile location, in all other cases most likley gives wrong results and unexpected behavior
  • there is already a variable the do the same named ${target_home}

I therefore would suggest to:

  1. Remove ECLIPSE_HOME from PDE and instead provide it by JDT
  2. Instead provide TARGET_HOME just in case anyone anywhere is still needing exactly this behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant