Add z/TPF specific configuration diagnostic information to Javacore #19219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Mar 26, 2024
jjohnst-us
force-pushed
the
master
branch
3 times, most recently
from
aad72f5
to
63c71c2
Compare
keithc-ca
requested changes
May 8, 2024
|
The summary in the commit message is too long (should be no more than 70 characters); suggest removing the second "z/TPF". |
jjohnst-us
changed the title
keithc-ca
requested changes
May 9, 2024
keithc-ca
reviewed
May 9, 2024
keithc-ca
requested changes
May 10, 2024
|
All recommended updates have been applied. |
keithc-ca
requested changes
May 13, 2024
Comment on lines
+1785
to
+1786
| #if defined(J9ZTPF) | ||
|
|
There was a problem hiding this comment.
Please put the blank line before the new block.
Comment on lines
+1789
to
+1791
| int rc; | ||
|
|
||
| rc = mprivatestats(&ztpfNativeStats); |
There was a problem hiding this comment.
Please join these so rc has an initial value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To assist with gathering context information for problem determination on z/TPF several fields dealing with system memory configuration and other settings are added to the Javacore for z/TPF only. The added sub-section is especially useful for determining if system limits were reached, and it can also be used for sizing system resources to run Java applications on z/TPF.