Don't mark wikitext API used by LSP4E as internal #523
Conversation
In versions 3.x this was api and internals are well hidden (esp in markdown plugin) thus the change to make everything internal was excessive and generates "Discouraged access" issues in LSP4E.
|
It was identified that lsp4e is not using latest wikitext - eclipse-cdt/cdt#779 . I tried to do that but it introduced extra discouraged access warnings thus this PR. I haven't searched why everything went internal at some point thus I'm making public only the parts that lsp4e needs that I am sure should be proper API. |
It's a major version bump which made too many things internal but that will be rectified via eclipse-mylyn/org.eclipse.mylyn#523
It's a major version bump which made too many things internal but that will be rectified via eclipse-mylyn/org.eclipse.mylyn#523
|
@akurtakov don't you think this discussion in the form of a monologue was too short to promote several packages to API? More API requires more effort from severely understaffed Mylyn team, and this is why all the Mylyn WikiText API was degraded according to #444 "Discouraged access" issues in LSP4E project or any other project is not a sufficient reason to promote anything to the API in Mylyn project. With all my respect to your contributions @akurtakov my current plan is to revert this PR before 2024-06 M3, because this is not how API should be promoted, even if some package was an API in the previous major version. cc: @merks |
|
I did it that way as it's actually partial revert of removal of API that has been such for years. As we obviously disagree I would prefer to hear from other committers (vote maybe?) before we come to conclusion. |
|
I have created #524 and let the community decide. I do believe this is the best way to settle it down in a good way according to what majority sees as best, if you disagree please comment. |
In versions 3.x this was api and internals are well hidden (esp in markdown plugin) thus the change to make everything internal was excessive and generates "Discouraged access" issues in LSP4E.