Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore releng for publishing Maven Docs to maven central #459

Open
ruspl-afed opened this issue Mar 2, 2024 · 8 comments
Open

Restore releng for publishing Maven Docs to maven central #459

ruspl-afed opened this issue Mar 2, 2024 · 8 comments

Comments

@ruspl-afed
Copy link
Contributor

Maven publishing is most likely not working after moving Mylyn Docs inside Maven and further releng work. Perhaps, we need to restore it.

@akurtakov how do you recommend to approach this? Should we have a separate Jenkins config that launches mvn from the specific entry point (special pom.xml with enumerated modules to publish) and with special set of options?
An outline of the steps to implement would be very helpful, because I'm not an experienced maven publisher.

@akurtakov
Copy link
Contributor

This was fully automated via https://github.com/eclipse-mylyn/org.eclipse.mylyn.docs/blob/master/Jenkinsfile-release so running some job using this jenkinsfile should be a good starting point.

ruspl-afed added a commit that referenced this issue Apr 6, 2024
Switch `org.eclipse.mylyn.wikitext.maven` to fixed versions ofr Mylyn
Docs until we restore Maven publishing with #459
ruspl-afed added a commit that referenced this issue Apr 6, 2024
Switch `org.eclipse.mylyn.wikitext.maven` to fixed versions ofr Mylyn
Docs until we restore Maven publishing with #459
@BeckerFrank
Copy link
Contributor

How can this work?

We now have version 3.0.48.202308291007 as a dependency. But build the version 4.3 and include this version in the updatesite!

@ruspl-afed
Copy link
Contributor Author

Maven Central and Eclipse Update Site are totally different things. Update site is easy to produce and committer rights are sufficient to upload. While uploading to Maven Central is quite a quest.

@BeckerFrank
Copy link
Contributor

Maven Central and Eclipse Update Site are totally different things. Update site is easy to produce and committer rights are sufficient to upload. While uploading to Maven Central is quite a quest.

That is not the point.
We use mvn clean verify for the Mylyn build, but Mylyn.docs needs mvn clean deploy to push the build result into the remote repository.

Why do you fix set the version to the old version (3.0.48.202308291007) for org.eclipse.mylyn.wikitext and org.eclipse.mylyn.wikitext.textile in the pom of org.eclipse.mylyn.wikitext.maven?

How are newer version of the projects org.eclipse.mylyn.wikitext and org.eclipse.mylyn.wikitext.textile build and come into the maven repository?

@ruspl-afed
Copy link
Contributor Author

Perhaps I miss something important: do you mean that you have a solution how to restore Mylyn Docs publishing? If so, please provide a PR.

ruspl-afed added a commit that referenced this issue Apr 7, 2024
Revert the fix for wikitext maven plugin dependencies
@ruspl-afed
Copy link
Contributor Author

@BeckerFrank I created a PR #487 to revert versions back to available in reactor

@BeckerFrank
Copy link
Contributor

Perhaps I miss something important: do you mean that you have a solution how to restore Mylyn Docs publishing? If so, please provide a PR.

We have the following calls to maven for builder Mylyn

mvn \
clean \
verify \
-B \
$MAVEN_PROFILES \
-Dmaven.repo.local=$WORKSPACE/.m2/repository \
-Dmaven.test.failure.ignore=true \
-Dmaven.test.error.ignore=true \
-Ddash.fail=false \
-Dorg.eclipse.justj.p2.manager.build.url=$JOB_URL \
-Dbuild.type=$BUILD_TYPE \
-Dgit.commit=$GIT_COMMIT

and Mylyn.Docs

mvn clean deploy -U -B -V -e -s /home/jenkins/.m2/settings-deploy-ossrh-docs.xml -Psign -Possrh -Dmaven.repo.local=$WORKSPACE/.m2/repository -Dtycho.buildqualifier.format=yyyyMMddHHmm -Dmaven.test.failure.ignore=true -Dmaven.test.error.ignore=true -Ddash.fail=false -Dgpg.passphrase="${KEYRING_PASSPHRASE}" -Dnexus.autoReleaseAfterClose="${PERFORM_RELEASE}"
  1. We can try to change the man build of Mylyn with the following changes.
  • replace verify \with deploy \
  • add
-U -V -e -s /home/jenkins/.m2/settings-deploy-ossrh-docs.xml \
-Possrh -Dgpg.passphrase="${KEYRING_PASSPHRASE}" \
 -Dnexus.autoReleaseAfterClose="${PERFORM_RELEASE}"
  1. try if we can run the original maven mylyn.docs command without the clean parameter and we add -f mylyn.docs/pom.xml

But how can we make sure that with our test we did not create problems in maven central?

Thougths?

@merks
Copy link
Contributor

merks commented Apr 8, 2024

Could you publish snapshots to repo.eclipse.org first. What's published to staging needs to be closed and release before it's final. Can the not-yet-closed thing be tested before closing and releasing?

ruspl-afed added a commit that referenced this issue Apr 10, 2024
Revert the fix for wikitext maven plugin dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants