-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove guava TypeToken #305
Comments
@BeckerFrank I saw you used the gson version in your GitLab code, any thoughts on this one? |
Yes, we use Gson and thus com.google.common.reflect.TypeToken to convert the REST responses from Bugzilla Rest and Gitlab Connector. This is also used in Common SDK for the test configuration. If we should no longer use Gson what should we use for serialization and deseralisation? |
I meant any thoughts on this issue. Can I replace the guava TypeToken with the gson TypeToken in GerritClient212? It's the remaining guava use Mylyn |
Yes, that should work |
#287 left com.google.common.reflect.TypeToken behind in GerritClient212.
Bugzilla uses com.google.gson.reflect.TypeToken for similar purposes.
Gerrit unit tests are currently disabled so unable to confirm if the two are functionally equivalent
The text was updated successfully, but these errors were encountered: