Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guava TypeToken #305

Closed
gnl42 opened this issue Nov 2, 2023 · 4 comments · Fixed by #522
Closed

Remove guava TypeToken #305

gnl42 opened this issue Nov 2, 2023 · 4 comments · Fixed by #522
Assignees

Comments

@gnl42
Copy link
Contributor

gnl42 commented Nov 2, 2023

#287 left com.google.common.reflect.TypeToken behind in GerritClient212.

Bugzilla uses com.google.gson.reflect.TypeToken for similar purposes.

Gerrit unit tests are currently disabled so unable to confirm if the two are functionally equivalent

@gnl42
Copy link
Contributor Author

gnl42 commented May 6, 2024

@BeckerFrank I saw you used the gson version in your GitLab code, any thoughts on this one?

@BeckerFrank
Copy link
Contributor

@BeckerFrank I saw you used the gson version in your GitLab code, any thoughts on this one?

Yes, we use Gson and thus com.google.common.reflect.TypeToken to convert the REST responses from Bugzilla Rest and Gitlab Connector. This is also used in Common SDK for the test configuration.

If we should no longer use Gson what should we use for serialization and deseralisation?

@gnl42
Copy link
Contributor Author

gnl42 commented May 8, 2024

I meant any thoughts on this issue.

Can I replace the guava TypeToken with the gson TypeToken in GerritClient212?

It's the remaining guava use Mylyn

@BeckerFrank
Copy link
Contributor

I meant any thoughts on this issue.

Can I replace the guava TypeToken with the gson TypeToken in GerritClient212?

Yes, that should work

@gnl42 gnl42 self-assigned this May 9, 2024
gnl42 added a commit that referenced this issue May 10, 2024
@gnl42 gnl42 linked a pull request May 10, 2024 that will close this issue
gnl42 added a commit that referenced this issue May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants