Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Mylyn Task Editor Integration #131

Open
BeckerFrank opened this issue Sep 20, 2023 · 21 comments
Open

Mylyn Task Editor Integration #131

BeckerFrank opened this issue Sep 20, 2023 · 21 comments

Comments

@BeckerFrank
Copy link
Contributor

In https://help.eclipse.org/latest/topic/org.eclipse.mylyn.wikitext.help.ui/help/Task-Editor-Integration.html?cp=59_1_2 I found the Task Editor Integration, but it looks like this feature is disabled / removed. Any plans to bring this back?

@ruspl-afed
Copy link
Contributor

Why not?

@akurtakov
Copy link
Contributor

I have removed it when Mylyn task editor dropped from simrel. I don't mind if anyone brings it back but I would not have the time for that.

@akurtakov
Copy link
Contributor

FWIW, code is still there https://github.com/eclipse-mylyn/org.eclipse.mylyn.docs/tree/master/wikitext/ui/org.eclipse.mylyn.wikitext.tasks.ui but not added in the pom.xml to try compiling it.

@BeckerFrank
Copy link
Contributor Author

BeckerFrank commented Sep 22, 2023

@akurtakov: Where can I find instructions to setup a Mylyn Docs Eclipse instance?
I can try to bring org.eclipse.mylyn.wikitext.tasks.ui back.

@merks
Copy link

merks commented Sep 22, 2023

I was trying to create an Oomph setup but I got completely confused by the structure. I too was planning to ask how one manually sets up an error free workspace. But then a dozen other things took precedence.

@akurtakov
Copy link
Contributor

What I've always been doing is import all projects from git and then close not build ones. Having such a workspace for long time doesn't require much changes from my side.
Please note that my interest in wikitext is limited to having it working as markdown renderer in lsp4e. This required a lot of effort to keep builds working but other improvements are for someone else to handle.

@merks
Copy link

merks commented Sep 23, 2023

So maybe at some point it would make sense to delete the not-built-ones? Certainly it makes sense to automate whatever the steps are to produce a workable workspace, because the definition of the "not build ones" is obviously far less than clear.

Note that I'm asking you to do anything!

@akurtakov
Copy link
Contributor

Not build ones are Mylyn Tasks and context integration AFAIK so maybe it's good that I haven't deleted them back in the days when Mylyn dropped from simrel.
Overall, I totally agree with you that projects shouldn't carry so much deadweight.

@merks
Copy link

merks commented Sep 23, 2023

FYI, this is as far as I got in the automation:

image

This is the result:

image

And then I got distracted by other activities...

@BeckerFrank
Copy link
Contributor Author

@akurtakov: can you share some information how you setup your workspace. @merks or I can the try to build a MylynDocs.setup to automate the steps.

@akurtakov
Copy link
Contributor

It's all done manual:

  • Import all projects from the git repo
  • Set the target platform to the one shipped in the git repo
  • Close plugins that are not built by the maven build

@BeckerFrank
Copy link
Contributor Author

It's all done manual:

  • Import all projects from the git repo
  • Set the target platform to the one shipped in the git repo
  • Close plugins that are not built by the maven build

I did this but have 904 errors. I think that I missed something because I get errors like.
Bundle 'org.eclipse.mylyn.wikitext' cannot be resolved from other MANIFEST.MF files.

In my Eclipse Instance I use the m2e plugin. Can this cause the errors?

@akurtakov
Copy link
Contributor

you have to compile once at the console to get the manifests generated

@merks
Copy link

merks commented Oct 6, 2023

Sorry I forgot to share the rough setup. I’ll try to remember tomorrow.

@BeckerFrank
Copy link
Contributor Author

OK now I have a problem with the mvn compile.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.1.0:run (default) on project org.eclipse.mylyn.wikitext.help.ui: An Ant BuildException has occured: Problem: failed to create task or type wikitext-to-eclipse-help
[ERROR] Cause: The name is undefined.
[ERROR] Action: Check the spelling.
[ERROR] Action: Check that any custom tasks/types have been declared.
[ERROR] Action: Check that any / declarations have taken place.
[ERROR]
[ERROR] around Ant part ...... @ 17:168 in /Users/frank/eclipse/mylyn-docs-master/git/org.eclipse.mylyn.docs/wikitext/ui/org.eclipse.mylyn.wikitext.help.ui/target/antrun/build-main.xml

@BeckerFrank
Copy link
Contributor Author

@akurtakov, @merks, @ruspl-afed What do you think of the following option to bring back the task editor integration?

We can do the following.

  1. add the Wikitext SDK from the Mylyn Docs update site to the target platform
  2. move the org.eclipse.mylyn.wikitext.tasks.ui project to the org.eclipse.mylyn Git repository
  3. change the plugin version to 4.1.0
  4. Add the Mylyn Docs updatesite as a repository reference

Thougths?

@akurtakov
Copy link
Contributor

So you would like to inverse the dependency chain. Wikitext to be required by Mylyn rather than wikitext requiring Mylyn. I don't see problem with that.

@merks
Copy link

merks commented Nov 15, 2023

Is merging the repos an option?

@ruspl-afed
Copy link
Contributor

I'm not sure that we can just merge these repositories, since Mylyn Docs repository uses very specific way of building bundles.
Moving org.eclipse.mylyn.wikitext.tasks.ui from Mylyn Docs to Mylyn looks much more realistic to me.
@BeckerFrank have you tried your plan locally?

@akurtakov
Copy link
Contributor

The way Mylyn Docs builds is really weird - when I first looked into it, it was Maven build forking into several extra maven builds each of them using different maven plugin versions and relying on artifacts being built/installed into local p2 repos.
I managed to get it to the single Maven reactor which we have now but this is still far from optimal and plain ugly and fragile. One more iteration of simplification is highly due if someone can spend the time on it.

@BeckerFrank
Copy link
Contributor Author

I'm not sure that we can just merge these repositories, since Mylyn Docs repository uses very specific way of building bundles. Moving org.eclipse.mylyn.wikitext.tasks.ui from Mylyn Docs to Mylyn looks much more realistic to me. @BeckerFrank have you tried your plan locally?

Yes, I have tried this locally. I noticed that Mylyn Docs does not have a latest P2 update site, so I used version [3.0.48] (https://download.eclipse.org/mylyn/docs/releases/3.0.48).

The way Mylyn Docs builds is really weird - when I first looked into it, it was Maven build forking into several extra maven builds each of them using different maven plugin versions and relying on artifacts being built/installed into local p2 repos. I managed to get it to the single Maven reactor which we have now but this is still far from optimal and plain ugly and fragile. One more iteration of simplification is highly due if someone can spend the time on it.

This is why I came up with the idea to move the one project from Mylyn Docs to Mylyn.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants