Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP4J 0.23.0 #807

Closed
35 tasks done
jonahgraham opened this issue Feb 13, 2024 · 11 comments
Closed
35 tasks done

LSP4J 0.23.0 #807

jonahgraham opened this issue Feb 13, 2024 · 11 comments
Labels
endgame Checklist of TODO lists to finish a release
Milestone

Comments

@jonahgraham
Copy link
Contributor

jonahgraham commented Feb 13, 2024

This is the Release plan and TODO list for LSP4J release v0.23.0.

Steps for Release

Items at the beginning of development

  • Create an Endgame Issue to track the release. As a starting point use documentation/releasing.md.
  • Ensure all previous Endgame issues are done.
  • Create a New milestone for the release
  • Check CHANGELOG.md is up to date. The changelog should have a version entry, release date, API Breakages and other information consistent with current entries in the changelog.
  • Check README.md is up to date. In particular that the planned release and which versions of DAP and LSP are support is listed.
  • Increment version of all feature.xml, pom.xml and any other place full version is used. (Easiest way is global find and replace, e.g. s/0.22.0/0.23.0/g, s/0.21.0/0.22.0/g and review changes.) Ensure that -SNAPSHOT is restored in the gradle/versions.gradle and releng/pom.xml
  • Enable sh './releng/deploy-build.sh' in releng/build.Jenkinsfile
  • Ensure the CI build is stable - it is always better to release a "Green Dot" build

Items in the days ahead of Release day:

  • Create release on PMI
  • Schedule the release and if needed schedule a release review on the PMI. A release review is needed every 12 months, not with each release.
  • Check CHANGELOG.md is up to date. The changelog should have a version entry, release date, API Breakages and other information consistent with current entries in the changelog.
  • Check README.md is up to date. In particular that the planned release and which versions of DAP and LSP are support is listed.
  • Check all closed PRs and Issues to make sure their milestone is set. (Note: this was not until after 0.10.0 release so many old PRs and Issues have no milestone, therefore only consider items back to approx 5 Nov 2020). This search may be useful to identify such closed issues
  • Create and analyse a japicmp report and publish it as part of the build. Ensure that the API versions are incremented accurately based on the report. The reports are part of the build in japicmp-report and generated by releng/runjapicmp.sh
  • Update links in changelog for japicmp from the nightly to the final location

Items on Release day:

  • Prepare the repo for release by:
  • Push the above change
  • Run the CI build
  • Mark the build as Keep Forever and add to the description v0.23.0
  • Deploy the release by running the Release CI job with parameters:
    • LSP4J_PUBLISH_LOCATION -> updates/releases/0.23.0 ( <-- check version number)
    • PROJECT -> lsp4j-multi-build/job/main
    • LSP4J_BUILD_NUMBER -> the build that was just run above
    • DRY_RUN -> false
  • Add to the deploy job description v0.23.0
  • Promote the staged repository to maven central
    • Login to Nexus
    • go to Staging Repositories, after a short delay the staged LSP4J release should appear (you may need to press Refresh)
    • click the staged LSP4J repo
    • press the Close button located in the toolbar. This runs activities, including checking various rules
    • once the rules are done (if successful), press the Release button (you may need to press Refresh to enable the Release button)
    • check https://search.maven.org/search?q=g:org.eclipse.lsp4j to make sure the latest release has arrived - this takes a while, 15 minutes for the files to be on the server and even longer for the search indexes to update
  • Update the meta-data on PMI downloads page
  • Tag the release. Example: git tag -a v0.23.0 HEAD -m"LSP4J 0.23.0" && git push origin v0.23.0
  • Contribute to Simrel. See Simrel contribution example
  • Create a release page on github
  • Link the Changelog to the release page
  • Make an announcement on lsp4j-dev based on the release page on github. Example on lsp4j-dev archives
  • Update documentation/releasing.md with any changes that may have been made to the release process.
  • Create the endgame for the next release right away, especially as version numbers and restoring -SNAPSHOT need to be done right away.
@jonahgraham jonahgraham added the endgame Checklist of TODO lists to finish a release label Feb 13, 2024
@jonahgraham jonahgraham added this to the 0.23.0 milestone Feb 13, 2024
jonahgraham added a commit that referenced this issue Feb 13, 2024
jonahgraham added a commit that referenced this issue Feb 13, 2024
@jonahgraham
Copy link
Contributor Author

We are up and running for 0.23.0 development. No particular schedule to release it, so if you have something you need releasing please just ask!

@cdietrich
Copy link
Contributor

@jonahgraham what is our current strategy regarding older deps (gson/guava/xtend)?

@jonahgraham
Copy link
Contributor Author

As long as it works with latest SimRel contents (i.e. Orbit/Maven content) then we can leave old versions. I assume you are referring to lower bounds on (and others):

'guava': '[32.1.2,34)',
'gson': '[2.9.1,2.11)',

@cdietrich
Copy link
Contributor

yes i mean the lower bounds. e.g. who in simrel is still on old gson

@jonahgraham
Copy link
Contributor Author

We don't need to keep running old version for other SimRel projects. We can (and should) update when ready.

@jonahgraham
Copy link
Contributor Author

With #827 there are a few updates for LSP4J's Debug Adapter Protocol (DAP) support. I suspect we should try to do a release for 2024-06 cycle. Thoughts?

@Soarex16
Copy link
Contributor

It would be great if the release could be sometime in May

@jonahgraham
Copy link
Contributor Author

Lets aim for May 14th, which should give all consumers in SimRel plenty of time to adjust.

@jonahgraham
Copy link
Contributor Author

I am working on completing this checklist now. If there are no blockers the 0.23.0 should be out in a few hours.

jonahgraham added a commit to jonahgraham/lsp4j that referenced this issue May 14, 2024
jonahgraham added a commit to jonahgraham/lsp4j that referenced this issue May 14, 2024
@cdietrich
Copy link
Contributor

nice and thx

@jonahgraham
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endgame Checklist of TODO lists to finish a release
Projects
None yet
Development

No branches or pull requests

3 participants