Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark completely optional parser rules as errors #1459

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bjthehun
Copy link
Contributor

@bjthehun bjthehun commented Apr 18, 2024

Closes #1400. Notes:

  • Fragments are not marked as optional.
  • Rules with actions only are not marked as optional.

Copy link
Contributor

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @bjthehun!

packages/langium/src/grammar/validation/validator.ts Outdated Show resolved Hide resolved
packages/langium/src/grammar/validation/validator.ts Outdated Show resolved Hide resolved
packages/langium/src/grammar/validation/validator.ts Outdated Show resolved Hide resolved
packages/langium/test/grammar/grammar-validator.test.ts Outdated Show resolved Hide resolved
@bjthehun bjthehun requested a review from msujew April 29, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completely optional parser rules should be marked as errors
2 participants