Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualified Name Scoping has an error in the code example #201

Closed
dimitrisfasoulas opened this issue Oct 31, 2023 · 1 comment · Fixed by #224
Closed

Qualified Name Scoping has an error in the code example #201

dimitrisfasoulas opened this issue Oct 31, 2023 · 1 comment · Fixed by #224
Labels
recipe Improvements or additions to recipes typo Error in typography or other minor textual error

Comments

@dimitrisfasoulas
Copy link

In the Qualified Name Scoping chapter in the code snippets there are two places where modelName is referenced inside a for loop:

...
for (const childNode of streamAllContents(document.parseResult.value)) {
...
  exportedDescriptions.push(this.descriptions.createDescription(modelNode, fullyQualifiedName, document));
...
}

If I'm not mistaken this should be childNode not modelNode

@msujew msujew added recipe Improvements or additions to recipes typo Error in typography or other minor textual error labels Oct 31, 2023
@msujew
Copy link
Contributor

msujew commented Oct 31, 2023

Yep, seems to be a typo. That should've been childNode indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Improvements or additions to recipes typo Error in typography or other minor textual error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants