Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments hotkey for the Playground #109

Closed
pluralia opened this issue Dec 1, 2022 · 4 comments
Closed

Add comments hotkey for the Playground #109

pluralia opened this issue Dec 1, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@pluralia
Copy link
Contributor

pluralia commented Dec 1, 2022

The comments hotkey Cmd + / (Ctrl + / for Windows) is very common editors feature --- would be cool to have it for the Langium Playground.

@pluralia pluralia added the enhancement New feature or request label Dec 1, 2022
@montymxb
Copy link
Contributor

montymxb commented Dec 2, 2022

I think this is supported in Monaco + Langium as is? @kaisalmen do you know more about this? Or perhaps it's necessary to add additional handling 🤔 . I've also noticed that it doesn't work as expected in Monaco at times, but I swear it did back in Sept. when I was preparing things for MiniLogo in the web.

@kaisalmen
Copy link
Contributor

kaisalmen commented Dec 2, 2022

There seem to be an issues. CTRL + K works in the monaco-editor built-in TypeScript editor, but there also CTRL + / does not work. Seems to be a more general issue. I have to investigate

@spoenemann
Copy link
Contributor

It could be related to the general problems of handling keyboard layouts in the browser. We have made quite a lot of effort to get it right in Theia: eclipse-theia/theia#4724

@montymxb
Copy link
Contributor

This works now, closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants