Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelmConfig.HelmType may use lombok @Getter #2930

Open
2 tasks
rohanKanojia opened this issue Apr 17, 2024 · 1 comment
Open
2 tasks

HelmConfig.HelmType may use lombok @Getter #2930

rohanKanojia opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

This class has explicit getters that can easily be replaced by using Lombok's @Getter annotation.

https://github.com/eclipse/jkube/blob/6ca26cdce98a073654be777d283f55215e6a1fbf/jkube-kit/helm/src/main/java/org/eclipse/jkube/kit/resource/helm/HelmConfig.java#L93-L115

Expected Behavior

Getter methods are removed and @Getter annotation is used

Acceptance Criteria

  • @Getter annotation is used in place of handwritten getters
  • Project compiles cleanly after running mvn clean install

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 17, 2024
@akshay11agrawal
Copy link
Contributor

@rohanKanojia Interested in picking this issue, let me know if I can work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants