You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If HelmMojo's @Override method is not doing anything different, there is no point keeping it.
Expected Behavior
HelmMojo's redundant method identical to its super method is removed.
Acceptance Criteria
redundant method is removed from HelmMojo
Project compiles cleanly after running mvn clean install
Before you start 🔴
👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
How to manually test my changes
Kubernetes
If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.
Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)
The text was updated successfully, but these errors were encountered:
@elizasorber Sorry this issue is created for people who have already contributed to the project before. Once you've made your first contribution, you can pick it.
We have a separate label first-timers-only for issues created for newcomers. Could you please take a look at those? For example #2928
Component
Kubernetes Maven Plugin
Task description
Description
I think this was probably introduced due to this refactor #2714
There is a method present in HelmMojo that is overriding a method from its superclass:
https://github.com/eclipse/jkube/blob/6ca26cdce98a073654be777d283f55215e6a1fbf/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/HelmMojo.java#L74-L77
However, if we look at the method in AbstractHelmMethod, it is identical to one in HelmMojo.
https://github.com/eclipse/jkube/blob/6ca26cdce98a073654be777d283f55215e6a1fbf/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/AbstractHelmMojo.java#L55-L57
If HelmMojo's
@Override
method is not doing anything different, there is no point keeping it.Expected Behavior
HelmMojo's redundant method identical to its super method is removed.
Acceptance Criteria
mvn clean install
Before you start 🔴
👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
How to manually test my changes
Kubernetes
If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.
OpenShift
If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.
Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the
?
icon and from the context menu selectCommand line tools
, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)The text was updated successfully, but these errors were encountered: