Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelmMojo : Remove redundant method identical to super method #2929

Open
2 tasks
rohanKanojia opened this issue Apr 17, 2024 · 4 comments
Open
2 tasks

HelmMojo : Remove redundant method identical to super method #2929

rohanKanojia opened this issue Apr 17, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rohanKanojia
Copy link
Member

Component

Kubernetes Maven Plugin

Task description

Description

I think this was probably introduced due to this refactor #2714

There is a method present in HelmMojo that is overriding a method from its superclass:

https://github.com/eclipse/jkube/blob/6ca26cdce98a073654be777d283f55215e6a1fbf/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/HelmMojo.java#L74-L77

However, if we look at the method in AbstractHelmMethod, it is identical to one in HelmMojo.
https://github.com/eclipse/jkube/blob/6ca26cdce98a073654be777d283f55215e6a1fbf/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/AbstractHelmMojo.java#L55-L57

If HelmMojo's @Override method is not doing anything different, there is no point keeping it.

Expected Behavior

HelmMojo's redundant method identical to its super method is removed.

Acceptance Criteria

  • redundant method is removed from HelmMojo
  • Project compiles cleanly after running mvn clean install

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 17, 2024
@elizasorber
Copy link
Contributor

Hi @rohanKanojia ! I'm a college student wanting to make my first contribution. Can I work on this issue?

@rohanKanojia
Copy link
Member Author

rohanKanojia commented Apr 17, 2024

@elizasorber Sorry this issue is created for people who have already contributed to the project before. Once you've made your first contribution, you can pick it.

We have a separate label first-timers-only for issues created for newcomers. Could you please take a look at those? For example #2928

@elizasorber
Copy link
Contributor

Thank you! I will check that out.

@Teja-11
Copy link
Contributor

Teja-11 commented Apr 18, 2024

Hi,

can i work on this? I have contributed to this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants