Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log what kind of build we are doing #1768

Open
sunix opened this issue Sep 26, 2022 · 6 comments
Open

log what kind of build we are doing #1768

sunix opened this issue Sep 26, 2022 · 6 comments
Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request UX

Comments

@sunix
Copy link
Member

sunix commented Sep 26, 2022

Agreed. I can't remember if we are already loggin what kind of build we are doing.
e.g.

  • Local Docker
  • Local Jib
  • OpenShift Docker
  • OpenShift S2I
  • ...

Originally posted by @manusa in #1279 (comment)

Also I came through another "kubernetes mode", it is confusing for the user ... what is a kubernetes mode?
Selection_698

@sunix sunix added enhancement New feature or request UX demoable Issues which can be demoed during the Sprint review meeting labels Sep 26, 2022
@manusa
Copy link
Member

manusa commented Oct 11, 2022

Building image (locally|in cluster) using (xxx) build strategy

@ShivangMishra
Copy link
Contributor

@manusa here logging the build strategy is simple by using getJKubeBuildStrategy() method of AbstractDockerMojo class. But could you please give me a hint on how to check whether the plugin is building image locally or in cluster ?

@rohanKanojia
Copy link
Member

I think we can consider Docker and Jib strategies to be local and OpenShift's Docker and S2I strategies to be in cluster.

@Krishancse
Copy link

i will take this

@ShivangMishra
Copy link
Contributor

i will take this

Already working on the issues under label UX...

@sunix
Copy link
Member Author

sunix commented Jun 26, 2023

May conflict with #1686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request UX
Projects
None yet
Development

No branches or pull requests

5 participants