Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: methods rely on instantiation of private constructors #1304

Open
DongChunHao opened this issue Apr 2, 2024 · 0 comments
Open

Bug: methods rely on instantiation of private constructors #1304

DongChunHao opened this issue Apr 2, 2024 · 0 comments
Assignees
@jjohnstn
Labels
bug Something isn't working
Milestone
4.33 M1

Comments

@DongChunHao
Copy link
Contributor

move methodUsingPrivateConstructor() to TargetClass

image

Refactoring results:

image
@jjohnstn jjohnstn self-assigned this May 17, 2024
@jjohnstn jjohnstn added the bug Something isn't working label May 17, 2024
@jjohnstn jjohnstn added this to the 4.33 M1 milestone May 17, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue May 18, 2024
@jjohnstn
Fix move instance processor to recognize an inaccessible constructor
8c8c51a 
- add logic to the MethodBodyRewriter so it will recognize a
  constructor call that will be inaccessible after moving and
  try to modify the accessibility of the constructor
- fix the ThisReferenceFinder to ignore field references made
  from a local variable
- add new tests to MoveInstanceMethodTests
- fixes eclipse-jdt#1304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjohnstn jjohnstn

Labels
bug Something isn't working
Projects
None yet
Milestone
4.33 M1
Development

No branches or pull requests
2 participants
@jjohnstn @DongChunHao