Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Move method refactoring relies on internal interfaces, resulting in compilation errors #1301

Open
DongChunHao opened this issue Apr 2, 2024 · 0 comments · May be fixed by #1412
Open

Bug: Move method refactoring relies on internal interfaces, resulting in compilation errors #1301

DongChunHao opened this issue Apr 2, 2024 · 0 comments · May be fixed by #1412
Assignees
@jjohnstn
Labels
bug Something isn't working
Milestone
4.32 M3

Comments

@DongChunHao
Copy link
Contributor

move myMethod() to TargetClass

image

Refactoring result：

image
@jjohnstn jjohnstn self-assigned this May 15, 2024
@jjohnstn jjohnstn added the bug Something isn't working label May 15, 2024
@jjohnstn jjohnstn added this to the 4.32 M3 milestone May 15, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue May 17, 2024
@jjohnstn
Fix move instance method when inner class is referenced
0edb021 
- fix MoveInstanceMethodProcessor to handle the cases where the
  method to move references a member class
- add new tests to MoveInstanceMethodTests
- fixes eclipse-jdt#1301
This was referenced May 17, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjohnstn jjohnstn

Labels
bug Something isn't working
Projects
None yet
Milestone
4.32 M3
Development

Successfully merging a pull request may close this issue.

Fix move instance method when inner class is referenced jjohnstn/eclipse.jdt.ui-1
2 participants
@jjohnstn @DongChunHao