Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug： Move method refactoring caused compilation errors due to method calls #1300

Closed
DongChunHao opened this issue Apr 2, 2024 · 0 comments · Fixed by #1405
Closed

Bug： Move method refactoring caused compilation errors due to method calls #1300

DongChunHao opened this issue Apr 2, 2024 · 0 comments · Fixed by #1405
Assignees
@jjohnstn
Labels
bug Something isn't working
Milestone
4.32 M3

Comments

@DongChunHao
Copy link
Contributor

Move moveMethod() to TargetClass

image

Refactoring results:

image
@jjohnstn jjohnstn self-assigned this May 13, 2024
@jjohnstn jjohnstn added the bug Something isn't working label May 13, 2024
@jjohnstn jjohnstn added this to the 4.32 M3 milestone May 13, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue May 15, 2024
@jjohnstn
Fix move of method with private method call when classes in same CU
8795bc4 
- fix MemberVisibilityAdjustor.thresholdTypeToMethod() so that when
  two classes are in same compilation unit but are separate, use
  a threshold of default (null) instead of private
- add new test to MoveInstanceMethodTests
- fixes eclipse-jdt#1300
@jjohnstn jjohnstn mentioned this issue May 15, 2024
Merged
3 tasks
jjohnstn added a commit that referenced this issue May 15, 2024
@jjohnstn
Fix move of method with private method call when classes in same CU (#…
2289ee0 
…1405)

* Fix move of method with private method call when classes in same CU

- fix MemberVisibilityAdjustor.thresholdTypeToMethod() so that when
  two classes are in same compilation unit but are separate, use
  a threshold of default (null) instead of private
- add new test to MoveInstanceMethodTests
- fixes #1300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjohnstn jjohnstn

Labels
bug Something isn't working
Projects
None yet
Milestone
4.32 M3
Development

Successfully merging a pull request may close this issue.

Fix move of method with private method call when classes in same CU jjohnstn/eclipse.jdt.ui-1
2 participants
@jjohnstn @DongChunHao