Refactor "extract method" false negative on break in loop inside the refactored code

[Alberth289346]

I was playing with eliminating left recursion in a grammar when JDT refused to extract a piece of code to a new method. I found this in Eclipse 2023-03, and confirmed it in 2024-03 as well.

There are two probably different refusals in the same original code, here I'll show the first one.

Reduced to a small example:

package completion2.grammar;

import java.util.List;

public class RefactorFalseNegativeBreakContinue {

    public static void falseNegativeBreakRefactor(List<List<String>> defs) {
        for (List<String> def: defs) {
            boolean isLeftRecursive = false;
            for (String rule: def) {
                if (!rule.isEmpty()) {
                    break;
                }
            }

            if (!isLeftRecursive) {
                continue;
            }
        }
    }
}

I want to refactor the body of the outer loop:

Message from Eclipse refactoring:

It looks asif JDT fails to see that the break is in an inner loop.

If either the break or the continue is removed, it works (although I haven't checked what it does then).

[Alberth289346]

Changed title to also state "extract method" and added the second refactor bug in #1292