Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#2289 Add 'iox' prefix to all 'unistd.hpp' entities #2290

Merged
merged 2 commits into from
May 16, 2024
Merged

iox-#2289 Add 'iox' prefix to all 'unistd.hpp' entities #2290

merged 2 commits into from
May 16, 2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented May 16, 2024 •
edited

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-2289-add-iox-prefix-to-all-unistd-header-entities branch 3 times, most recently from 982e871 to 8868c5a Compare May 16, 2024 00:52
@elBoberido elBoberido requested a review from elfenpiff May 16, 2024 00:54
@elBoberido elBoberido self-assigned this May 16, 2024
@elBoberido elBoberido added the refactoring Refactor code without adding features label May 16, 2024
@elBoberido elBoberido force-pushed the iox-2289-add-iox-prefix-to-all-unistd-header-entities branch from 8868c5a to aa6149f Compare May 16, 2024 01:08
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.07%. Comparing base (f6dc4e1) to head (aa6149f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
+ Coverage   78.06%   78.07%   +0.01%     
==========================================
  Files         432      432              
  Lines       15912    15920       +8     
  Branches     2303     2303              
==========================================
+ Hits        12421    12429       +8     
  Misses       2644     2644              
  Partials      847      847
Flag Coverage Δ
unittests 77.89% <94.28%> (+0.01%) ⬆️
unittests_timing 14.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
iceoryx_hoofs/posix/auth/source/posix_user.cpp 76.78% <100.00%> (ø)
iceoryx_hoofs/posix/filesystem/source/file.cpp 32.28% <100.00%> (ø)
...ryx_hoofs/posix/ipc/source/posix_shared_memory.cpp 64.37% <100.00%> (ø)
...oofs/posix/utility/source/system_configuration.cpp 77.77% <100.00%> (ø)
iceoryx_platform/linux/source/grp.cpp 100.00% <100.00%> (ø)
iceoryx_platform/linux/source/unistd.cpp 91.66% <100.00%> (+4.16%) ⬆️
...e/iceoryx_posh/internal/popo/notification_info.inl 100.00% <ø> (ø)
...posh/include/iceoryx_posh/internal/roudi/roudi.hpp 60.00% <ø> (ø)
iceoryx_posh/source/roudi/roudi.cpp 64.91% <100.00%> (ø)
iceoryx_hoofs/posix/auth/source/posix_group.cpp 79.41% <85.71%> (ø)
... and 1 more

@elBoberido elBoberido merged commit d285ed1 into eclipse-iceoryx:main May 16, 2024
25 checks passed
@elBoberido elBoberido deleted the iox-2289-add-iox-prefix-to-all-unistd-header-entities branch May 16, 2024 05:40
@elBoberido elBoberido linked an issue May 16, 2024 that may be closed by this pull request
Add 'iox' prefix to all functions and types in the platform abstraction #2289
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfenpiff elfenpiff elfenpiff approved these changes

Assignees

@elBoberido elBoberido

Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'iox' prefix to all functions and types in the platform abstraction
2 participants
@elBoberido @elfenpiff