Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pull requests #9

Open
Bananeweizen opened this issue Dec 19, 2023 · 3 comments
Open

Disable pull requests #9

Bananeweizen opened this issue Dec 19, 2023 · 3 comments

Comments

@Bananeweizen
Copy link
Contributor

Description

I would like to disable pull requests in all jgit and egit repositories (except for the .eclipsefnd repos). It seems that is not possible via otterdog directly. Any objections against raising a gitlab issue for doing so?
In other projects like the Apache project I have also seen repositories explicitly being marked as "mirror" repositories in the GitHub UI. Does anyone know how that can be done, and whether that would be useful for our repositories, too?

And when PRs are disabled, is there any possibility of creating a kind of notice/banner to explain what to do instead?

Motivation

avoiding people to create PRs, as has already happened

Alternatives considered

No response

Additional context

No response

@Bananeweizen
Copy link
Contributor Author

Looking into documentation and discussion, there seems to be nothing in the official settings. We can do all of the following:

  • disable forking via Otterdog settings (must be set for each repo)
  • create a PR template which explicitly describes that people shall use gerrithub instead
  • have a github action to automatically close the PR with a message describing the gerrithub workflow
  • create a single pseudo PR which says that PRs will not be accepted

I would try the first 3 in that order, if someone agrees.

@msohn
Copy link
Member

msohn commented Dec 19, 2023

Pull requests can also be imported as Gerrit changes by committers here
https://eclipse.gerrithub.io/plugins/github-plugin/static/pullrequests.html
That's a one-way street, AFAIK importing updates of existing PRs is not supported.
To make that clear to the contributor I closed the PR on the GitHub side after importing it into Gerrit
telling the user that the code review and eventually necessary updates have to happen there.

@Bananeweizen
Copy link
Contributor Author

I really recommend everyone adds the above import URL to his/her own menu settings in gerrithub. E.g. mine starts like this now:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants