Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.eclipse.fx.ui.dialogs.TitleAreaDialog: Dialog content doesn't grow vertically when resizing the dialog #388

Open
TyPh00nCdr opened this issue Jan 7, 2020 · 3 comments

Comments

@TyPh00nCdr
Copy link

TyPh00nCdr commented Jan 7, 2020

A TitleAreaDialog's content doesn't grow vertically when resizing the dialog.

We currently work around this by getting the dialogContent-BorderPane and setting its VGrow-Priority, in order to have its parent VBox container handle the vertical resizing accordingly:

VBox.setVgrow(dialogContent, Priority.ALWAYS);
@tomsontom
Copy link
Contributor

Would you like to conbtribute a PR?

@TyPh00nCdr
Copy link
Author

I'd love to. What's the correct target-platform to set after I cloned the code? After importing the cloned repository and running mvn clean verify on releng/org.eclipse.fx.releng I seem to have no functioning target-platform.

@tomsontom
Copy link
Contributor

The current main branch is 3.x not master! Master is what will lead one day to 4.x. So just change to that branch and PDE should resolve everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants