Ensure Export-Package is correctly added to bundle MANIFEST for guice… #894
Conversation
|
Thank you for the fix, however to merge it we would need you to sign the ECA here, using the same e-mail as in the commit (or e-mail linked to the same GitHub account): https://accounts.eclipse.org/user/186802/eca/3.1.0 |
|
@dcokan I cannot merge your PR until you sign the Contributor Agreement. |
|
Hi David,
Just signed ECA :)
Regards, Dawid
…On Sun, Jan 21, 2024 at 4:23 PM David Matějček ***@***.***> wrote:
@dcokan <https://github.com/dcokan> I cannot merge your PR until you sign
the Contributor Agreement.
—
Reply to this email directly, view it on GitHub
<#894 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWHIK5X776CEFWQHIHZKWTYPUXGJAVCNFSM6AAAAAA5MVLC7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGY3DSNRXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It seems Eclipse Foundation doesn't see it, did you use the same e-mail as in the commit? |
dcokan
force-pushed
the
893_missingExportPackageInGuiceBridge
branch
from
0644595
to
d2a6904
Compare
|
I've just set up right commit author. Please retry
On Mon, Jan 22, 2024 at 9:20 PM David Matějček ***@***.***>
wrote:
… Hi David, Just signed ECA :) Regards, Dawid
… <#m_8181578971897774382_>
On Sun, Jan 21, 2024 at 4:23 PM David Matějček *@*.*> wrote: @dcokan
<https://github.com/dcokan> https://github.com/dcokan
<https://github.com/dcokan> I cannot merge your PR until you sign the
Contributor Agreement. — Reply to this email directly, view it on GitHub
<#894 (comment)
<#894 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWHIK5X776CEFWQHIHZKWTYPUXGJAVCNFSM6AAAAAA5MVLC7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGY3DSNRXGY
<https://github.com/notifications/unsubscribe-auth/ACWHIK5X776CEFWQHIHZKWTYPUXGJAVCNFSM6AAAAAA5MVLC7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGY3DSNRXGY>
. You are receiving this because you were mentioned.Message ID: @.*>
It seems Eclipse Foundation doesn't see it, did you use the same e-mail as
in the commit?
—
Reply to this email directly, view it on GitHub
<#894 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWHIK733BV7SIYE4PBERHTYP3CZTAVCNFSM6AAAAAA5MVLC7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUG42DCMRTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
There is still discrepancy between author and committer: |
…-bridge