Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #888

Open
Pandrex247 opened this issue Sep 11, 2023 · 4 comments
Open

Versioning #888

Pandrex247 opened this issue Sep 11, 2023 · 4 comments

Comments

@Pandrex247
Copy link
Contributor

Pandrex247 commented Sep 11, 2023

Hi,

What versioning system does this project use?
The last patch release (3.0.4) was a gigantic update of what looks like every single dependency this project uses.

The updates were extensive enough that this project no longer compiles under JDK 11 despite that being set as the minimum version. I believe this is due to it pulling in Spring 6.x rather than 5.x. This presumably slipped through due to the CI also being updated to compile using JDK 17, meaning the published artefacts require also you to be using JDK 17.

The dependency updates also include an update to OSGi R7, which is what brings in the fairly substantial change that, unless explicitly specified not to, the manifests of the modules will now include import statements for JDK packages and expect them to be resolved.

My personal stance is that all of these updates should have gone into a 3.1.0 or 4.0.0 release, not what would typically be seen as a bug fix or service release. I suggest that the active dev branch version is updated appropriately.

@reftel
Copy link

reftel commented Sep 21, 2023

I believe this issue would have been found before release if the release process involved writing release notes. Could that please be considered?

@Pandrex247
Copy link
Contributor Author

It looks like we're now bumping the required JDK version to 17 in a 3.0.5 release to satisfy the updated Spring dependency that dependabot brought in: #900

I would reiterate that this is not something that typically goes into a patch release and would push for a version increment to 3.1.0 or 4.0.0.

@Pandrex247
Copy link
Contributor Author

Related 3.0.5 PR: #931

@arjantijms
Copy link
Contributor

We need to do a 3.1 (or 3.2?) anyway, to support things like Jakarta Annotations 3. (for now in a milestone version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants