ServerLoader.lookupProviderClasses throw NPE

[russgold]

The ServiceLoader.lookupProviderClasses method dereferences the field _me without first ensuring that it is null. This frequently results in a NullPointerException. It is caught, so the functionality works, but it complicates debugging NPEs expected in other code. The lookupProviderInstances right above it does check for null. It would very nice if this method did so as well.

[minfrin]

Also found this here:

Cannot invoke "org.glassfish.hk2.osgiresourcelocator.ServiceLoader.lookupProviderClasses1(java.lang.Class)" because "org.glassfish.hk2.osgiresourcelocator.ServiceLoader._me" is null

It appears possible to reach this line without running initialize, or after running reset:

glassfish-hk2-extra/osgi-resource-locator/src/main/java/org/glassfish/hk2/osgiresourcelocator/ServiceLoader.java

Line 108 in 13b7ba5

return _me.lookupProviderClasses1(serviceClass);