Content-Type application/octet-stream set By Default

[efiege]

Dear EDC-Team,

we have made the observation, that the Content-Type-header of the request, that is send to the consumer, gets automatically set to application/octet-stream by default. The observation was made, when executing a ProviderPush.

Is this the intended behaviour?

We would expect that the Content-Type-header gets forwarded from the producer over the data-plane to the consumer. Such that this information does not get lost.

@SebastianOpriel

[ndr-brt]

Theoretically the Content-Type is extracted from the incoming request and set into the DataFlowRequest.properties field:

Connector/extensions/data-plane/data-plane-public-api/src/main/java/org/eclipse/edc/connector/dataplane/api/controller/DataFlowRequestSupplier.java

Lines 65 to 70 in a195712

	Optional.ofNullable(contextApi.mediaType())
	.ifPresent(mediaType -> {
	props.put(MEDIA_TYPE, mediaType);
	props.put(BODY, contextApi.body());
	});
	return props;

Then it is set on the contentType of the HttpRequestParam object:

Connector/extensions/data-plane/data-plane-http/src/main/java/org/eclipse/edc/connector/dataplane/http/params/decorators/BaseSourceHttpParamsDecorator.java

Lines 46 to 51 in a195712

	Optional.ofNullable(extractContentType(address, request))
	.ifPresent(ct -> {
	params.contentType(ct);
	params.body(extractBody(address, request));
	});
	params.nonChunkedTransfer(false);

that it's used to create the RequestBody object with the contentType:

Connector/extensions/data-plane/data-plane-http/src/main/java/org/eclipse/edc/connector/dataplane/http/params/HttpRequestFactory.java

Lines 74 to 82 in a195712

	private RequestBody createRequestBody(HttpRequestParams params, @Nullable Supplier<InputStream> bodySupplier) {
	var contentType = params.getContentType();
	if (bodySupplier == null || contentType == null) {
	return null;
	}
	return params.isNonChunkedTransfer()
	? new NonChunkedTransferRequestBody(bodySupplier, contentType)
	: new ChunkedTransferRequestBody(bodySupplier, contentType);
	}

so, theoretically it should work, if that's not the case, I'd say that it could be a bug.

[efiege]

Thanks for this fast answer.

The DataFlowRequestSupplier you mentioned is only used from the DataPlanePublicApiController if I see it correctly. As a result it is used for the ConsumerPull and not used for the ProviderPush method. The observation we made was related to the ProviderPush.

You also mentioned that

the Content-Type is extracted from the incoming request

but our observation was related to passing the Content-Type header, which is coming from the response of the provider-system, through the data-plane into the consumer-system.

If this is still not intended, I will create a bug report,

[ndr-brt]

whops, I overlooked that detail, yes, looking at the implementation seems that no Content-Type is extracted from the response and by consequence, it is not forwarded to the consumer.
It definitely deserves an issue.
Ref.:

Connector/extensions/data-plane/data-plane-http/src/main/java/org/eclipse/edc/connector/dataplane/http/pipeline/HttpDataSource.java

Line 59 in e6522fe

return success(Stream.of(new HttpPart(name, body.byteStream())));