From 0118042cb454303a6dbcc3b9e27e45932fa67f41 Mon Sep 17 00:00:00 2001 From: Erik Boasson Date: Tue, 26 Mar 2024 14:42:49 +0100 Subject: [PATCH] Fix race condition in security FSM unit test Signed-off-by: Erik Boasson --- src/security/core/tests/fsm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/security/core/tests/fsm.c b/src/security/core/tests/fsm.c index 28ac31336b..384dbabf8c 100644 --- a/src/security/core/tests/fsm.c +++ b/src/security/core/tests/fsm.c @@ -424,12 +424,12 @@ CU_Test(ddssec_fsm, create, .init = fsm_control_init, .fini = fsm_control_fini) CU_ASSERT (visited_auth == 0xff); ddsrt_mutex_unlock (&g_lock); - /* Check correct callback parameter passing (from fsm to user defined methods) */ - CU_ASSERT(correct_arg && correct_fsm); dds_security_fsm_free (fsm_auth); /* Check whether timeout callback has NOT been invoked */ + /* Check correct callback parameter passing (from fsm to user defined methods) */ ddsrt_mutex_lock (&g_lock); + CU_ASSERT (correct_arg && correct_fsm); CU_ASSERT (visited_timeout == 0); ddsrt_mutex_unlock (&g_lock); }