Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant custom rules checkbox in preferences #418

Open
enriozuni opened this issue Jan 25, 2021 · 0 comments
Open

Redundant custom rules checkbox in preferences #418

enriozuni opened this issue Jan 25, 2021 · 0 comments

Comments

@enriozuni
Copy link
Contributor

With the new preference page options added in this PR #417, the load custom rules checkbox in preferences seems to be a little redundant. It currently loads all the rules in the resources folder of the core plugin: the JCA, BC, Tink rulesets, and the rules from the project which is analyzed. I find this unnecessary as an option since there already are options for loading the rules from specific rulesets and also for loading other rules from the project that is to be analyzed. My suggestion would be to remove this option in the future.

If it is decided to keep this checkbox, a suggestion would be to change the name of it because it is a little ambiguous. A better name would be load all possible rules or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant