Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing mylyn.wikitext dependency #779

Merged
merged 1 commit into from May 12, 2024

Conversation

MarkZ3
Copy link
Contributor

@MarkZ3 MarkZ3 commented May 10, 2024

lsp4e depends on mylyn.wikitext but it could not be found. For example: https://github.com/eclipse-cdt/cdt/actions/runs/9026888723/job/24804874235?pr=778

@@ -14,6 +14,9 @@
<unit id="org.eclipse.test.feature.group" version="0.0.0" />
<unit id="org.eclipse.unittest.ui" version="0.0.0" />
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/mylyn/updates/release/latest/" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkZ3 SimRel version of Mylyn WikiText
Since LSP4E is full of innovations I wonder why they still don't upgrade Mylyn WikiText.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an easy answer - people doing and caring for releng are so few and spread over so many projects that such things are easily missed. Best would be if PRs are provided for such changes wherever needed.
I have to admit that with lsp4e being with very few deps I manage to find time for updating its deps only few times per year (and usually this is driven by LSP4J ).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkZ3 SimRel version of Mylyn WikiText

Sorry is this a question or suggestion?

@jonahgraham
Copy link
Member

I assume build is failing because of #780 - I'll try to solve the immediate issue soon.

@jonahgraham
Copy link
Member

I added this commit to #782 to get a clean build.

@jonahgraham jonahgraham merged commit 5f2fcd0 into eclipse-cdt:main May 12, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants