[#657] CDT cannot be built on Java 21 due to security manager changes #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruspl-afed
force-pushed
the
657
branch
3 times, most recently
from
49806ee
to
5db917a
Compare
|
What if we include debug/org.eclipse.cdt.debug.application.product back to the general modules list @jonahgraham ? Currently it is outside of the CI control. |
…ger changes * Switch CI to Java 21 * Remove config generation for debug application * Remove `org.eclipse.osgi.services` from `proxy.server` product * Remove `org.eclipse.osgi.services` from `org.eclipse.cdt.debug.application.product` product * Move `org.eclipse.cdt.debug.application.product` from profile to general part Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
|
Well, no idea if Debug RCP is fully functional, but it starts after building locally from this branch |
We have 1 test failure that looks unrelated |
|
Merging this one to unblock further development in |
Sorry that I missed this before. It was in its own profile because it is so fragile that it comes in and out of the main build regularly.
I don't understand how debug application works if this is removed? The install script won't be able to find the config.ini: The screenshot you took in #761 (comment) - how was that created? Was it with https://github.com/eclipse-cdt/cdt/blob/main/StandaloneDebugger.md I'm about to raise an issue on standalone debugger and will cross reference this issue. Frankly I think my proposal is to remove it now or soon, so don't spend too much time addressing the above questions. |
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
May 12, 2024
The maintenance of having a streamlined standalone debugger that starts as fast as possible is no longer possible. See for example eclipse-cdt#591 - therefore when using standalone debugger, use the same sets of plug-ins/features as the product it is installed in uses. The side effect is that the standalone debugger in this use case will start slower and extra "stuff" will be present in this UI. For people just building the standalone debugger, provide a minimum feature set. This will be many more bundles than before, but should still provide a reasonably small set that starts well. This simplification also includes removing the the duplicates set of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These provided a simplified version of CDT's documentation targetted at just standalone debugger. However there are a few problems related to this duplication: - The two sets of docs were not kept in sync - The standalone docs appear in the online help, leading to duplicated entries - With the config.ini changes above, there is no way to exclude the main docs in the standalone case, so remove the duplicate A number of directly related clean-ups are included too: - Remove the `ConfigGenerator.java` that stopped being referenced in PR eclipse-cdt#761 - Complete the removal of `build-standalone-debugger-rcp` profile that was started in eclipse-cdt#761. There is a small drawback to not having this profile, the standalone debugger is very slow to build compared to the rest of CDT. If this becomes a problem, restoring this profile along with the changes made in eclipse-cdt#761 is reasonable. Fixes eclipse-cdt#781 - bring debug.product's licenses up to date - modernize command line args to eclipse when using debug.product
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
May 12, 2024
The maintenance of having a streamlined standalone debugger that starts as fast as possible is no longer possible. See for example eclipse-cdt#591 - therefore when using standalone debugger, use the same sets of plug-ins/features as the product it is installed in uses. The side effect is that the standalone debugger in this use case will start slower and extra "stuff" will be present in this UI. For people just building the standalone debugger, provide a minimum feature set. This will be many more bundles than before, but should still provide a reasonably small set that starts well. This simplification also includes removing the the duplicates set of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These provided a simplified version of CDT's documentation targetted at just standalone debugger. However there are a few problems related to this duplication: - The two sets of docs were not kept in sync - The standalone docs appear in the online help, leading to duplicated entries - With the config.ini changes above, there is no way to exclude the main docs in the standalone case, so remove the duplicate A number of directly related clean-ups are included too: - Remove the `ConfigGenerator.java` that stopped being referenced in PR eclipse-cdt#761 - Complete the removal of `build-standalone-debugger-rcp` profile that was started in eclipse-cdt#761. There is a small drawback to not having this profile, the standalone debugger is very slow to build compared to the rest of CDT. If this becomes a problem, restoring this profile along with the changes made in eclipse-cdt#761 is reasonable. - bring debug.product's licenses up to date - modernize command line args to eclipse when using debug.product Fixes eclipse-cdt#781
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
May 12, 2024
The maintenance of having a streamlined standalone debugger that starts as fast as possible is no longer possible. See for example eclipse-cdt#591 - therefore when using standalone debugger, use the same sets of plug-ins/features as the product it is installed in uses. The side effect is that the standalone debugger in this use case will start slower and extra "stuff" will be present in this UI. For people just building the standalone debugger, provide a minimum feature set. This will be many more bundles than before, but should still provide a reasonably small set that starts well. This simplification also includes removing the the duplicates set of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These provided a simplified version of CDT's documentation targetted at just standalone debugger. However there are a few problems related to this duplication: - The two sets of docs were not kept in sync - The standalone docs appear in the online help, leading to duplicated entries - With the config.ini changes above, there is no way to exclude the main docs in the standalone case, so remove the duplicate A number of directly related clean-ups are included too: - Remove the `ConfigGenerator.java` that stopped being referenced in PR eclipse-cdt#761 - Complete the removal of `build-standalone-debugger-rcp` profile that was started in eclipse-cdt#761. There is a small drawback to not having this profile, the standalone debugger is very slow to build compared to the rest of CDT. If this becomes a problem, restoring this profile along with the changes made in eclipse-cdt#761 is reasonable. - bring debug.product's licenses up to date - modernize command line args to eclipse when using debug.product Fixes eclipse-cdt#781
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
May 12, 2024
The maintenance of having a streamlined standalone debugger that starts as fast as possible is no longer possible. See for example eclipse-cdt#591 - therefore when using standalone debugger, use the same sets of plug-ins/features as the product it is installed in uses. The side effect is that the standalone debugger in this use case will start slower and extra "stuff" will be present in this UI. For people just building the standalone debugger, provide a minimum feature set. This will be many more bundles than before, but should still provide a reasonably small set that starts well. This simplification also includes removing the the duplicates set of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These provided a simplified version of CDT's documentation targetted at just standalone debugger. However there are a few problems related to this duplication: - The two sets of docs were not kept in sync - The standalone docs appear in the online help, leading to duplicated entries - With the config.ini changes above, there is no way to exclude the main docs in the standalone case, so remove the duplicate A number of directly related clean-ups are included too: - Remove the `ConfigGenerator.java` that stopped being referenced in PR eclipse-cdt#761 - Complete the removal of `build-standalone-debugger-rcp` profile that was started in eclipse-cdt#761. There is a small drawback to not having this profile, the standalone debugger is very slow to build compared to the rest of CDT. If this becomes a problem, restoring this profile along with the changes made in eclipse-cdt#761 is reasonable. - bring debug.product's licenses up to date - modernize command line args to eclipse when using debug.product Fixes eclipse-cdt#781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.eclipse.osgi.servicesfromproxy.serverproductorg.eclipse.osgi.servicesfromorg.eclipse.cdt.debug.application.productproductorg.eclipse.cdt.debug.application.productfrom profile togeneral part
Fixed #657