BIRT 4.15 milestone, "Build Project" shows 48 JS-library issues due to missing APIs of Rhino 1.7.14 (dependency update #1567)

[speckyspooky]

I started after the finding of the BIRT 4.15 topics a complete project rebuild.
The result was that I got compilation issues with some specific Debugger-JS-Classes:

package: org.eclipse.birt.report.debug.core

• sub-packages: org.eclipse.birt.report.debug.internal.core.vm
• sub-packages: org.eclipse.birt.report.debug.internal.core.vm.js

@merks
Ed, have I forgot something or due you get the same messages if you create a general BIRT project build?
I never used the JS-Debugger and it seems to be not part of our test cases.

Errors after "Build Project"

[speckyspooky]

It seems the the missing debug-classes are part of the rhino engine but I cannot find the classes at the rhino-1.7.14-library.
Can we add this classes as dependencies in another way to avoid the errors?

Package:
org.mozilla.javascript.debug

Source
https://javadoc.io/static/org.mozilla/rhino/1.7.14/org/mozilla/javascript/debug/package-summary.html

[merks]

That package is present:

And the access rules make the internal package accessible:

So I see no errors and the Maven/Tycho build has no errors.

Maybe you need to do a clean build?

[speckyspooky]

@merks

1. I have refreshed all dependencies for the project from "Maven Repo".

2. I can see according to your side that the rhino.jar includes the debug-classes.

3. Started the "Project Build" from eclipse-menu based on the project root. But I didn't get the ".classpath" file into this part and the error keeps there.

4. Started the Build with "Tycho" and see now an issue with your changes from the platform.

What do I'm wrong because it seems to me that I haven't all packages and the build doesn't create the ".classpath" correctly.
Have you an idea what I must change...? (I'm confused on it)

[merks]

To see .* resources you must unfilter them:

To update the target platform you must run the setup tasks for that:

The projects don't need Maven dependencies to be updated. Don't do that! There is simply no need to do a Maven build in your workspace, so avoid that too. Doing such a build makes a mess of the workspace such that one needs to do a Project -> Clean... afterwards to repair the damage.

Of course it's fine to do a Maven build if you need the results for some reason, but it does make a mess of the workspace and you will need to do a clean build afterwards if you want to use the workspace properly again.

The compile error you show was already fixed by my commit.

00fe855

Please ensure that you use master (not an outdated master from your fork) but rather the real current master.

[speckyspooky]

Thanks for assistency. I created a completely new branch with all your changes.
I refreshed the "Module Target" and configured the "Filters" according to your hints and clean up the workspace.

Result:

• I can see the ".classpath"

• Now it looks like yours! :o)

• The JS-debugger-errors are solved

• Only thing, with the changes of your target it seems to me that we got the issue BIRT 4.15 milestone: eclipse-designer (all-in-one) shows error on 1st report and the report will be hidden after restart (eclipse-restart-option) #1588 & BIRT 4.15 rcp-designer: "XML Source"-tab of report not available (empty page due to NullPointerException, provider = null) #1589 on top, because know the problem is reproducable on my dev-environment.

But one of the topics solved successfully through your support, many thanks!

[merks]

Yes, using the latest of everything might result in new problems but those are problems that people will see when they install BIRT in tomorrow's release, so need to be fixed. Please be careful not to mess up the classpaths with maven things. :-(

[speckyspooky]

Please wait with the release, we cannot start with a new version and the 2 bugs.
It would make no sense to do this till we have a stable fix of it.

[merks]

Sorry, I mean the SimRel release which is definitely tomorrow. The BIRT release can happen on our own schedule and of course I will not do that until the lights are green! 😄