Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[Lifx] direct IP address support #3913

Closed
paulianttila opened this issue Jul 30, 2017 · 3 comments · Fixed by #4231
Closed

[Lifx] direct IP address support #3913

paulianttila opened this issue Jul 30, 2017 · 3 comments · Fixed by #4231

Comments

@paulianttila
Copy link
Contributor

Currently lifx addon implementation is based on lifx discovery protocol, which works fine when bulbs and server is running on the same network. For security reason, my lifx bulbs are in dedicated VLAN and server (OH) is running on different VLAN. Broadcast communication is not allowed between different VLANs, so lifx addon can't find bulbs and therefore I can't control them.

Currently only deviceId (mac address) can be manually configured to addon, and if I have understand correctly, addon then finds the IP address of the bulb by using UDP broadcast communication.

My request is to enhance the addon and make possible to configure IP address to bulb configuration, which addon could then use directly.

@htreu
Copy link
Contributor

htreu commented Aug 1, 2017

Hey @wborn, is this something you could have a look at? Thanks in advance :-)

@wborn
Copy link
Contributor

wborn commented Sep 9, 2017

@paulianttila With #4231 you can now optionally configure the host of the light. I've succesfully tested controlling lights from another machine on another location via a VPN and Docker in bridge mode when UDP broadcasts don't work. :-)

@paulianttila
Copy link
Contributor Author

@wborn, just tested your changes and host parameter seems to works great. Now I can control bulbs in my vlan environment without python script. Big thanks to you 👍

kaikreuzer pushed a commit that referenced this issue Sep 25, 2017
…s and improvements (#4231)

* [LIFX] Add optional host configuration parameter, support new products

* Add host configuration parameter for lights that do not respond to UDP broadcasts (fixes #3913)
* Add support for new products (most notably the new Downlights)
* Add deviceId configuration parameter pattern to prevent mistakes/exceptions
* Fix static code analysis findings
* Make broadcastEnabled final
* Makes the LIFX Binding periodically update network interface information. This for instance resolves the issue that network interfaces are not (or still) being used for broadcasts after they go up (or down).
* The code for this information was duplicated across the LifxLightDiscovery and LifxLightCommunicationHandler classes and has now been extracted into LifxNetworkUtil.
* All utility classes have now been grouped in the .util package.
* Make Device ID an optional configuration paramater, use lambdas and fix updating properties
* Update Thing status to configuration error when Device ID and Host are null
* Introduce logId property so logging identifies light depending on MAC/IP configuration
* Add logId where missing to simplify debugging
* Use lambdas for listener registration and iteratating over listeners
* Resolve @nonnull warnings
* Fix properties not always being updated
* Use a LifxLightContext for sharing common variables between handler helper objects
* Improve exception handling by catching specific exceptions and using more specific error messages
* Don't set host property on discovered lights

Signed-off-by: Wouter Born <eclipse@maindrain.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants