Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Grey listing? #94

Open
jinnatar opened this issue Feb 4, 2019 · 4 comments
Open

FR: Grey listing? #94

jinnatar opened this issue Feb 4, 2019 · 4 comments

Comments

@jinnatar
Copy link

jinnatar commented Feb 4, 2019

I find myself wanting grey listing every now and then. For example, some cron failures are due to temporarily failed DNS lookups every now and then and it's frequent enough to be annoying. But, if I whitelist it I won't see a situation where DNS fails constantly.

Proposal at a high level:

  • Add field to whitelist entries called rate limit or perhaps disable threshold?
  • rate limit would be X matches in Y time
  • if rate limit is tripped, stop applying the filter to subsequent messages

Benefit: I can whitelist something that fails every now and then by it's nature but still catch if it starts failing more then usual.

@proditis
Copy link
Contributor

proditis commented Feb 6, 2019

Hello @Artanicus,

That sounds like a good idea. I could certainly see this work under a lot of different situations.

I'll start work on the design of it a little bit and post back with my progress.

@jinnatar
Copy link
Author

jinnatar commented Mar 4, 2020

Any news on this one?

@proditis
Copy link
Contributor

proditis commented Mar 5, 2020

Sorry but I'm quite busy with other projects atm and haven't got the time to look into this.

If you feel up to it give it a go, otherwise it will have to wait a "bit" longer.

@jinnatar
Copy link
Author

jinnatar commented Mar 8, 2020

Took a look at the triggers that perform whitelist filtering and I don't see a way to implement rules specific to a whitelist that wouldn't have a bad performance hit. In any case it would require a significant rework of core functionality. Sadly I don't think I have the skills for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants