Skip to content

Latest commit

 

History

History
84 lines (60 loc) · 6.36 KB

CONTRIBUTE.md

File metadata and controls

84 lines (60 loc) · 6.36 KB

This is the contribution guide for Inflation, a Python package for implementations of the inflation technique for causal inference. Contributions are very welcome and appreciated!

You can begin contributing by opening an issue on the GitHub repository to report bugs, request features, etc. Now we will outline some guidelines for contributing to the code, and for contributing to the documentation.

Style guidelines

Inflation code is developed according standard practices in Python development. We do not have strict style guidelines, but we do have some suggestions.

  • In general, try to follow PEP 8 (code) and PEP 257 (docstrings) guidelines.
  • Avoid going over 79 characters per line.
  • Write docstrings in numpy style, or else Sphinx automatic documentation generation will be buggy.
  • Use annotations for type hints in the objects’ signature.

How to contribute to the code

If you want to contribute to the code, please fork the repository and submit a pull request.

Install in develop mode

It is recommended to install the package in develop mode, which can be done with the following command in the terminal after downloading the source code:

pip install -e .

This way the package does not need to reinstalled after every modification.

Testing

If you add new features, please write tests for them. Testing is done within the Unit testing framework. You can copy one of the existing tests to start with, and then adapt it to your code modification. To run the tests on your own computer, once you have cloned the repository, you can run the following command in the terminal:

python -m unittest -v

You can also run a specific test only, e.g. python -m unittest -v test/test_sdp.py. The -v option is used to print the test results.

If you are using a code editor, typically it includes a way to automatically find tests and run them. Here are specific instructions for some popular code editors:

  • Spyder. Install the unittest plugin. Then create a new project in the Projects tab and choose as existing directory your local copy of the repository. Then in the Run tab there is the option of running tests.
  • Visual Studio Code: Open universal search with Ctrl+Shift+P (universal search), search for Configure Tests and choose unittest. Then you can run all the tests in the Test tab in the Primary Side Bar.
  • PyCharm: You can either create a new project and pull from the repository, or, if you have already downloaded the repository, you can open it in PyCharm. Then, under File > Settings > Tools > Python Integrated Tools, choose Unittest for Default test runner. Context actions are then updated and you can run individual tests (using the "play" arrow next to the test function) or all of them.

One suggestion is to write tests for a function in advance, and then write the function itself. This way you can easily see if your function is working as expected. Another suggestion is to use breakpoints, which allow you to stop a program mid-way and inspect variable values, to debug your function. Most coding environments, such as Visual Studio Code, support this feature.

Special note about test debugging for Visual Studio Code users

At the time of writing this (September 2022), there is a bug when trying to debug tests with breakpoints. It seems that the best solution is to add the following to the .vscode/launch.json file:

{
    "name": "Python: Test debug config",
    "type": "python",
    "request": "test",
    "console": "integratedTerminal",
    "logToFile": true
}

How to contribute to the documentation

The documentation is built using Sphinx. The webpage is hosted with GitHub Pages. Currently, GitHub Pages is set to look for an index.html file in the /docs folder in the repository. In the future, we will look into migrating the HTML build to the gh-pages branch of the repository, leading to a cleaner repository.

Since the documentation has already been created, you do not need to generate a configuration file.

The main file is docs/index.rst, which outlines the structure of the documentation. One can update index.rst to include additional files or to remove them. It needs to be written in the reStructuredText format.

Sphinx extensions

The following are the extensions added to Sphinx to generate the documentation, and you will need to have them installed if you want to locally build the documentation:

  • m2r2: For the conversion of Markdown files to reStructuredText files.
  • nbsphinx: To have Jupyter notebooks as pages.
  • sphinx.ext.autodoc: To create .rst files from the class and method code docstrings.
  • sphinx.ext.autodoc.typehints: To have typehints in the documentation.
  • sphinx.ext.githubpages: To create the .nojekyll file on generated HTML directory to publish the document on GitHub Pages.
  • sphinx.ext.napoleon: To correctly identify numpy-style docstrings.
  • sphinx.ext.viewcode: To add links to highlighted source code.
  • sphinx-rtd-theme: For the Read the docs theme.
  • sphinx_copybutton: For allowing to copy code snippets.

These extensions and other specifications are found in the conf.py file. They allow for two important quality of life improvements in maintaining the documentation, namely, the ability to have Markdown documents and Jupyter notebooks as sections of the documentation. Future plans are to migrate everything to MyST serialisation.

Build the HTML documentation

Once you have done all your modifications, you can build the documentation by running the following command in the terminal on the docs/ directory:

make html

One can also build the documentation in other formats, such as PDF, using make pdf. To push to the website your changes to the documentation, you can do so through a pull request.