Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise finally not working #84

Open
carlobeltrame opened this issue Apr 17, 2021 · 0 comments
Open

Promise finally not working #84

carlobeltrame opened this issue Apr 17, 2021 · 0 comments

Comments

@carlobeltrame
Copy link
Member

carlobeltrame commented Apr 17, 2021

Reportedly, on 1.x, the following does not work:

this.api.href(this.api.get(), 'invitation', {
        action: 'resend',
      }).then(postUrl => this.api.post(postUrl, {}))
        .finally(() => /* this is never called */)

This is probably caused by QueryablePromise, which we have removed in 2.x. We should write a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant