Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3 so that you can "disable" the auth key and now its also prep… #5

Closed
wants to merge 2 commits into from
Closed

Conversation

bernhardh
Copy link

Fixes #3 so that you can "disable" the auth key and now its also prepared for further config settings (more commits will follow)

@bernhardh bernhardh closed this Dec 3, 2020
@eboye
Copy link
Owner

eboye commented Dec 4, 2020

Why did you close this? Not working? I would test it and merge it if it works.

@bernhardh
Copy link
Author

bernhardh commented Dec 4, 2020

I started to use your package yesterday and this issue was my first problem I found with it, so I tried to fix it.

But after that I found a lot of other problems and missing features (at least for my usecase) and that I would have to completly change you package, so I created a new one from scratch (https://github.com/bernhardh/nova-translation-editor). The main differences are:

  • Allow to disable auth
  • Save changes all at once and not every single input field
  • Use textareas instead of input fields for longer translations
  • Multilanguage support
  • Allow to add new rows to a group/file
  • (subjective opinion) nicer design
  • Filter

It wouldn't be fair from me to "dictate" you to change your package to work as I expect/need it to work.

Finally I decieded to close this pull request, since it had a non backward compatible breaking change.

If you wanna fix this issue for your users, just delete the auth key from your config/trans_editor.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config files should not be merged
2 participants