Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--replace option not working for msix installer #196

Open
jasonvooo opened this issue Feb 1, 2024 · 4 comments
Open

--replace option not working for msix installer #196

jasonvooo opened this issue Feb 1, 2024 · 4 comments
Labels
Milestone

Comments

@jasonvooo
Copy link

Thanks for releasing 6.0 with msix installer!

I am running into an issue with using the --replace option when using jsign to sign a msix package. I am under the impression that when using this flag it should replace the existing signature and replace it with the new signature however when running it results in an artefact that has no signature present.

@ebourg
Copy link
Owner

ebourg commented Feb 5, 2024

I'm not aware of an issue with the replacement of MSIX signatures. This case is covered by a unit test in APPXSignerTest.

If you change the extension of the signed file to .zip and open the archive, do you see an AppxSignature.p7x entry?

@jasonvooo
Copy link
Author

When exporting as a zip I see the AppxSignature.p7x file but when opening the file through explorer properties you cannot see the digital signature.

Before and after running jsign with --replace
image

image

@ebourg
Copy link
Owner

ebourg commented Feb 9, 2024

Could you send the two files, before and after replacing the signature, to ebourg@apache.org please? I'd like to inspect them.

@ebourg ebourg added the bug label Feb 9, 2024
@ebourg
Copy link
Owner

ebourg commented Feb 14, 2024

I've been able to reproduce this behavior, the missing 'Digital Signatures' tab happens when the primary signature of the package is made with a certificate whose CN doesn't match the publisher name in the app manifest. signtool usually returns an error code 0x8007000B when verifying such files.

I'll modify Jsign to check the CN before signing MSIX packages.

ebourg added a commit that referenced this issue Feb 14, 2024
@ebourg ebourg added this to the 6.1 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants