Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests are failing for R < 4.0 #281

Open
IndrajeetPatil opened this issue Mar 17, 2023 · 0 comments
Open

Some tests are failing for R < 4.0 #281

IndrajeetPatil opened this issue Mar 17, 2023 · 0 comments

Comments

@IndrajeetPatil
Copy link
Member

IndrajeetPatil commented Mar 17, 2023

cf. https://github.com/easystats/correlation/actions/runs/6338093602/job/17214505364

On Ubuntu

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-display_print_dataframe.R:8:3'): display and print method works - markdown ──
Snapshot of code has changed:
old vs new
  "Code"
  "  display(correlation(iris))"
  "Output"
- "  "
- "  "
- "  Table: Correlation Matrix (pearson-method)"
- "  "
- "  |Parameter1   |   Parameter2 |     r |         95% CI | t(148) |         p |"
- "  |:------------|:------------:|:-----:|:--------------:|:------:|:---------:|"
- "  |Sepal.Length |  Sepal.Width | -0.12 |  (-0.27, 0.04) |  -1.44 | 0.152     |"
- "  |Sepal.Length | Petal.Length |  0.87 |   (0.83, 0.91) |  21.65 | < .001*** |"
- "  |Sepal.Length |  Petal.Width |  0.82 |   (0.76, 0.86) |  17.30 | < .001*** |"
- "  |Sepal.Width  | Petal.Length | -0.43 | (-0.55, -0.29) |  -5.77 | < .001*** |"
- "  |Sepal.Width  |  Petal.Width | -0.37 | (-0.50, -0.22) |  -4.79 | < .001*** |"
- "  |Petal.Length |  Petal.Width |  0.96 |   (0.95, 0.97) |  43.39 | < .001*** |"
- "  p-value adjustment method: Holm (1979)"
- "  Observations: 150"
+ "   [1] \"Table: Correlation Matrix (pearson-method)\"                                  "
+ "   [2] \"\"                                                                            "
+ "   [3] \"|Parameter1   |   Parameter2 |     r |         95% CI | t(148) |         p |\""
+ "   [4] \"|:------------|:------------:|:-----:|:--------------:|:------:|:---------:|\""
+ "   [5] \"|Sepal.Length |  Sepal.Width | -0.12 |  (-0.27, 0.04) |  -1.44 | 0.152     |\""
+ "   [6] \"|Sepal.Length | Petal.Length |  0.87 |   (0.83, 0.91) |  21.65 | < .001*** |\""
+ "   [7] \"|Sepal.Length |  Petal.Width |  0.82 |   (0.76, 0.86) |  17.30 | < .001*** |\""
+ "   [8] \"|Sepal.Width  | Petal.Length | -0.43 | (-0.55, -0.29) |  -5.77 | < .001*** |\""
+ "   [9] \"|Sepal.Width  |  Petal.Width | -0.37 | (-0.50, -0.22) |  -4.79 | < .001*** |\""
+ "  [10] \"|Petal.Length |  Petal.Width |  0.96 |   (0.95, 0.97) |  43.39 | < .001*** |\""
+ "  [11] \"p-value adjustment method: Holm (1979)\"                                      "
+ "  [12] \"Observations: 150\"                                                           "
+ "  attr(,\"format\")"
+ "  [1] \"pipe\""
+ "  attr(,\"class\")"
+ "  [1] \"knitr_kable\" \"character\"  "

* Run `testthat::snapshot_accept('display_print_dataframe')` to accept the change.
* Run `testthat::snapshot_review('display_print_dataframe')` to interactively review the change.
── Failure ('test-display_print_dataframe.R:16:3'): display and print method works - HTML ──
Snapshot of code has changed:
old[7:18] vs new[7:20]
  "  --------------------------------------------------------------------"
  "  wt         |        mpg | -0.87 | [-0.93, -0.74] | -9.56 | < .001***"
  "  p-value adjustment method: Holm (1979)Observations: 32"
- "  "
- "  "
- "  Table: Correlation Matrix (pearson-method)"
- "  "
- "  |Parameter1 | Parameter2 |     r |         95% CI | t(30) |         p |"
- "  |:----------|:----------:|:-----:|:--------------:|:-----:|:---------:|"
- "  |wt         |        mpg | -0.87 | (-0.93, -0.74) | -9.56 | < .001*** |"
- "  p-value adjustment method: Holm (1979)"
- "  Observations: 32"
+ "  [1] \"Table: Correlation Matrix (pearson-method)\"                             "
+ "  [2] \"\"                                                                       "
+ "  [3] \"|Parameter1 | Parameter2 |     r |         95% CI | t(30) |         p |\""
+ "  [4] \"|:----------|:----------:|:-----:|:--------------:|:-----:|:---------:|\""
+ "  [5] \"|wt         |        mpg | -0.87 | (-0.93, -0.74) | -9.56 | < .001*** |\""
+ "  [6] \"p-value adjustment method: Holm (1979)\"                                 "
+ "  [7] \"Observations: 32\"                                                       "
+ "  attr(,\"format\")"
+ "  [1] \"pipe\""
+ "  attr(,\"class\")"
+ "  [1] \"knitr_kable\" \"character\"  "

* Run `testthat::snapshot_accept('display_print_dataframe')` to accept the change.
* Run `testthat::snapshot_review('display_print_dataframe')` to interactively review the change.
── Failure ('test-display_print_matrix.R:7:5'): display and print method works - markdown ──
Snapshot of code has changed:
old vs new
  "Code"
  "  display(summary(correlation(iris)))"
  "Output"
- "  "
- "  "
- "  Table: Correlation Matrix (pearson-method)"
- "  "
- "  |Parameter    | Petal.Width | Petal.Length | Sepal.Width |"
- "  |:------------|:-----------:|:------------:|:-----------:|"
- "  |Sepal.Length |     0.82*** |      0.87*** |       -0.12 |"
- "  |Sepal.Width  |    -0.37*** |     -0.43*** |             |"
- "  |Petal.Length |     0.96*** |              |             |"
- "  p-value adjustment method: Holm (1979)"
+ "  [1] \"Table: Correlation Matrix (pearson-method)\"                "
+ "  [2] \"\"                                                          "
+ "  [3] \"|Parameter    | Petal.Width | Petal.Length | Sepal.Width |\""
+ "  [4] \"|:------------|:-----------:|:------------:|:-----------:|\""
+ "  [5] \"|Sepal.Length |     0.82*** |      0.87*** |       -0.12 |\""
+ "  [6] \"|Sepal.Width  |    -0.37*** |     -0.43*** |             |\""
+ "  [7] \"|Petal.Length |     0.96*** |              |             |\""
+ "  [8] \"p-value adjustment method: Holm (1979)\"                    "
+ "  attr(,\"format\")"
+ "  [1] \"pipe\""
+ "  attr(,\"class\")"
+ "  [1] \"knitr_kable\" \"character\"  "

* Run `testthat::snapshot_accept('display_print_matrix')` to accept the change.
* Run `testthat::snapshot_review('display_print_matrix')` to interactively review the change.

[ FAIL 3 | WARN 7 | SKIP 13 | PASS 88 ]
@IndrajeetPatil IndrajeetPatil changed the title Some examples are failing for R < 4.0 Some tests are failing for R < 4.0 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant