Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Introduce versioningit #932

Open
amotl opened this issue May 2, 2023 · 3 comments
Open

Packaging: Introduce versioningit #932

amotl opened this issue May 2, 2023 · 3 comments

Comments

@amotl
Copy link
Member

amotl commented May 2, 2023

Proposal

Use versioningit.

Details

GH-931 already added versioningit to the Dockerfiles. I recently started using it on one or two projects, and I love it.

References

Originally posted by @amotl in #931 (comment)

@gutzbenj
Copy link
Member

gutzbenj commented May 9, 2023

Dear @amotl ,

it doesn't look like it supports poetry at this moment, so we#d have to go with https://github.com/mtkennerly/poetry-dynamic-versioning / https://github.com/mtkennerly/dunamai .

Or would this be the right moment to totally switch to either one of hatch / pdm?

@amotl
Copy link
Member Author

amotl commented May 9, 2023

Thanks for the research. If we want to keep a lock file, we can have a look at Hatch or PDM. Also, there is another candidate by Armin Ronacher, only recently released. Or, if we don't necessarily need a lock file, we can also think about going back to native setuptools, as it excellently supports pyproject.toml-based projects today, which wasn't the case when Wetterdienst was started, I believe.

@gutzbenj
Copy link
Member

Dear @amotl , I'd still go with hatch or pdm because they have functionalities for creating a venv OOTB. hatch doesn't currently support lock files however it is a tool developed by PyPA which should not be underestimated regarding support that splits upon those tools atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants