Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated dataset in Geosphere, update needed in endpoint #1286

Open
bluearrow98 opened this issue Apr 30, 2024 · 5 comments
Open

deprecated dataset in Geosphere, update needed in endpoint #1286

bluearrow98 opened this issue Apr 30, 2024 · 5 comments

Comments

@bluearrow98
Copy link

bluearrow98 commented Apr 30, 2024

Describe the bug
Geosphere recently seemed to have updated their dataset resource. I was trying to retrieve the snow depth data in a certain region, however it is shown missing when I access through wetterdienst. On comparing the data directly accessing from Geopshere API, I discovered that the resource used in wetterdienst is deprecated.

To Reproduce
Steps to reproduce the behavior:

Request the data:

reqData = GeosphereObservationRequest(
    parameter=GeosphereObservationParameter.SNOW_DEPTH,
    resolution=GeosphereObservationResolution.DAILY,
    start_date='2023-11-22',
    end_date= '2024-04-19'
)

reqData.filter_by_station_id(station_id='87').values.all()

The output I get:
Bildschirmfoto 2024-04-30 um 10 42 43

Expected behavior
The data is available. But Geosphere seem to have updated their dataset resource. You can find all the list of deprecated resources here: https://dataset.api.hub.geosphere.at/v1/docs/user-guide/resource.html. There is also alternative endpoint name suggested for all those resources.

@bluearrow98
Copy link
Author

bluearrow98 commented Apr 30, 2024

By the way, I would love to help contributing to updating this if you are alright with it :)

@gutzbenj
Copy link
Member

gutzbenj commented May 2, 2024

Dear @bluearrow98 , thanks for reporting the change! It would be great if you setup a PR and I'll guarantee quick merge! Do you need assistance?

@bluearrow98
Copy link
Author

Yes, I am working on it! All the parameters need to be updated as well unfortunately and this is causing some problems. Currently, debugging it. I'll notify you once I update it :)

@gutzbenj
Copy link
Member

gutzbenj commented May 2, 2024

If you have some pain points that really had troubled you, please let me know and I'll try to add that to the docs!

@bluearrow98
Copy link
Author

Just set up a PR. Noticed that the request function was setting the start_date to be default even when a user gives one (but no end_date). Fixed that as well.

Also, it is painful to see such hardcoded parameter for each resolution haha. I plan to take this up as a small project to automate this somehow ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants